[00:01:39] *** DanRubel has quit IRC
[00:32:32] *** DanRubel has joined #eclipse-e4
[00:34:58] *** benny`work has joined #eclipse-e4
[00:47:30] *** benny`work has quit IRC
[02:02:37] *** briandealwis has quit IRC
[02:37:45] <DanRubel> Is ModelComponent -> positionInParent used anywhere?
[02:38:46] <rcjsuen> Well, it's supposed to be used for constructing the model when reading people's extensions.
[02:39:26] <DanRubel> That's what I thought, but when I set a breakpoint it was never hit
[02:39:42] <DanRubel> Couldn't find doc or example using it either
[02:40:58] <DanRubel> I thought I might use it to control where my menu item appeared in the "Window" menu
[02:41:30] <rcjsuen> mm
[02:41:32] <DanRubel> Something like positionInParent="after=some.other.menu.id"
[02:41:43] <DanRubel> Maybe there is a better way?
[02:41:46] <rcjsuen> Does it just get tacked on at the end?
[02:41:53] <DanRubel> Yes
[02:42:01] <DanRubel> It appears, but always at the end
[02:44:44] <rcjsuen> It should be done in org.eclipse.e4.workbench.ui.internal.ModelExtensionProcessor.addModelExtensions()
[02:44:48] <rcjsuen> but I guess it's not implemented
[02:49:16] <DanRubel> Should I open a bug?
[02:49:53] <rcjsuen> DanRubel: Please do.
[02:55:38] <DanRubel> Bug 305811
[02:55:45] <DanRubel> https://bugs.eclipse.org/bugs/show_bug.cgi?id=305811
[03:24:36] *** DanRubel has quit IRC
[04:08:16] *** rcjsuen has quit IRC
[09:16:44] *** tomschindl has joined #eclipse-e4
[09:41:32] *** tomschindl has quit IRC
[10:38:52] *** kartben has joined #eclipse-e4
[10:58:09] *** kartben1 has joined #eclipse-e4
[10:58:09] *** kartben has quit IRC
[11:34:45] *** kartben has joined #eclipse-e4
[11:35:48] *** kartben1 has quit IRC
[11:38:53] *** kartben has quit IRC
[11:38:59] *** kartben has joined #eclipse-e4
[12:32:47] *** rcjsuen has joined #eclipse-e4
[13:51:03] <paulweb515> rcjsuen: Should I just apply your model test patch?  Or does it need some work if we decide to skip user bindings for now?  If they work we can always leave them in
[13:51:38] <rcjsuen> paulweb515: Just apply the patch as-is.
[13:52:06] <rcjsuen> It alrdy tests that add/remove a binding works (though not very exhaustive).
[13:52:24] <rcjsuen> I'll open new bugs as individual cases fail.
[13:52:36] <paulweb515> OK, I'll fiddle with that
[13:53:20] *** DanRubel has joined #eclipse-e4
[13:53:32] <paulweb515> sweet, that did the trick
[13:56:02] <rcjsuen> what I didn't test are some of the new features you added  (like adding a new binding table)
[13:56:10] <rcjsuen> and those context strings
[13:56:20] <rcjsuen> but I guess since it's just a java.lang.String it'd be persisted...or so I think
[13:57:01] *** tjwatson has joined #eclipse-e4
[14:41:37] *** DanRubel has quit IRC
[14:57:16] *** DanRubel has joined #eclipse-e4

top