[00:01:39] *** DanRubel has quit IRC
[00:32:32] *** DanRubel has joined #eclipse-e4
[00:34:58] *** benny`work has joined #eclipse-e4
[00:47:30] *** benny`work has quit IRC
[02:02:37] *** briandealwis has quit IRC
[02:37:45] <DanRubel> Is ModelComponent -> positionInParent used anywhere?
[02:38:46] <rcjsuen> Well, it's supposed to be used for constructing the model when reading people's extensions.
[02:39:26] <DanRubel> That's what I thought, but when I set a breakpoint it was never hit
[02:39:42] <DanRubel> Couldn't find doc or example using it either
[02:40:58] <DanRubel> I thought I might use it to control where my menu item appeared in the "Window" menu
[02:41:30] <rcjsuen> mm
[02:41:32] <DanRubel> Something like positionInParent="after=some.other.menu.id"
[02:41:43] <DanRubel> Maybe there is a better way?
[02:41:46] <rcjsuen> Does it just get tacked on at the end?
[02:41:53] <DanRubel> Yes
[02:42:01] <DanRubel> It appears, but always at the end
[02:44:44] <rcjsuen> It should be done in org.eclipse.e4.workbench.ui.internal.ModelExtensionProcessor.addModelExtensions()
[02:44:48] <rcjsuen> but I guess it's not implemented
[02:49:16] <DanRubel> Should I open a bug?
[02:49:53] <rcjsuen> DanRubel: Please do.
[02:55:38] <DanRubel> Bug 305811
[02:55:45] <DanRubel> https://bugs.eclipse.org/bugs/show_bug.cgi?id=305811
[03:24:36] *** DanRubel has quit IRC
[04:08:16] *** rcjsuen has quit IRC
[09:16:44] *** tomschindl has joined #eclipse-e4
[09:41:32] *** tomschindl has quit IRC
[10:38:52] *** kartben has joined #eclipse-e4
[10:58:09] *** kartben1 has joined #eclipse-e4
[10:58:09] *** kartben has quit IRC
[11:34:45] *** kartben has joined #eclipse-e4
[11:35:48] *** kartben1 has quit IRC
[11:38:53] *** kartben has quit IRC
[11:38:59] *** kartben has joined #eclipse-e4
[12:32:47] *** rcjsuen has joined #eclipse-e4
[13:51:03] <paulweb515> rcjsuen: Should I just apply your model test patch?  Or does it need some work if we decide to skip user bindings for now?  If they work we can always leave them in
[13:51:38] <rcjsuen> paulweb515: Just apply the patch as-is.
[13:52:06] <rcjsuen> It alrdy tests that add/remove a binding works (though not very exhaustive).
[13:52:24] <rcjsuen> I'll open new bugs as individual cases fail.
[13:52:36] <paulweb515> OK, I'll fiddle with that
[13:53:20] *** DanRubel has joined #eclipse-e4
[13:53:32] <paulweb515> sweet, that did the trick
[13:56:02] <rcjsuen> what I didn't test are some of the new features you added  (like adding a new binding table)
[13:56:10] <rcjsuen> and those context strings
[13:56:20] <rcjsuen> but I guess since it's just a java.lang.String it'd be persisted...or so I think
[13:57:01] *** tjwatson has joined #eclipse-e4
[14:41:37] *** DanRubel has quit IRC
[14:57:16] *** DanRubel has joined #eclipse-e4
[16:11:47] *** borisb6i1 has quit IRC
[16:12:26] *** borisb6i has joined #eclipse-e4
[16:16:22] *** borisb6i1 has joined #eclipse-e4
[16:18:29] *** briandealwis has joined #eclipse-e4
[16:19:47] *** borisb6i has quit IRC
[16:32:43] *** borisb6i1 has quit IRC
[16:56:11] <rcjsuen> paulweb515: Reproduced. Very odd.
[16:56:54] <paulweb515> we got a lot of errors in the current build tests, and a lot of unhappy injection output on the build log
[16:57:09] <paulweb515> Once I get my model changes up to snuff, I'll run another build today
[16:57:38] <rcjsuen> Some of that uninjection rubbish should've been gone i tho
[16:57:39] <rcjsuen> t
[17:00:43] <rcjsuen> er wait i can't reproduce it
[17:10:29] *** magnet_ has joined #eclipse-e4
[17:31:49] <DanRubel> In Eclipse 3.x, you can add a visibleWhen expression to menu contributions in plugin.xml. I could not find anything in the e4 UI workbench model corresponding to this. Should this be added to the model or added by the developer programmatically on an as needed basis?
[17:33:38] <paulweb515> DanRubel: there would be some reference to an expression in the model, but ... I don't want to re-implement core expressions in the model ... both XML and the model I think are too verbose for simple expressions
[17:34:17] <paulweb515> DanRubel: one thing we considered was allowing the expressions to be javascript instead (although they'd have to be in a file URI, probably)
[17:40:15] *** tomschindl has joined #eclipse-e4
[17:40:46] <tomschindl> paulweb515: looks like the key stuff is not workin 100%
[17:41:00] <tomschindl> java.lang.NullPointerException
[17:41:00] <tomschindl> 	at org.eclipse.e4.ui.bindings.internal.BindingServiceImpl.getBestSequenceFor(BindingServiceImpl.java:155)
[17:41:25] <paulweb515> tomschindl: what are you running to get that?
[17:41:35] <tomschindl> my model editor tool
[17:41:56] <tomschindl> i can check in my changes to align with your code
[17:42:02] <tomschindl> then you can try it your own
[17:42:27] <tomschindl> the problem in reality is
[17:42:28] <tomschindl> Could not set manager
[17:42:28] <tomschindl> java.lang.IllegalArgumentException: Unable to find value for "org.eclipse.e4.ui.bindings.internal.BindingTableManager"
[17:42:53] <tomschindl> probably something is missing from my launch config
[17:42:57] <tomschindl> ist that possible?
[17:43:01] <rcjsuen> tomschindl: That's from the reconciler, I think?
[17:43:11] <paulweb515> tomschindl: I mean what are you running against?
[17:43:26] <tomschindl> hm probably this is the problem
[17:43:35] <tomschindl> I haven't cleaned the startups
[17:44:05] <rcjsuen> yes would be good to wipe the target's deltas file
[17:44:07] <paulweb515> tomschindl: does your model plugin run in the e4 SDK legacy product?  That wouldn't create an E4Application or E4workbench and so won't work correctly
[17:44:08] <rcjsuen> and maybe even launch cofnig
[17:44:26] <tomschindl> no I run the start e4 one
[17:44:35] <paulweb515> rcjsuen: I didn't have any problems, although if you did add key bindings then they would show up in deltas
[17:44:51] <paulweb515> tomschindl: you are running the e4 ide app?  Or the legacy e4 ide app?
[17:45:57] <rcjsuen> I assumed the error was from me
[17:46:02] <rcjsuen> but then i realized i throw ISEs not IAEs
[17:46:55] <tomschindl> i#m running swt.E4Application
[17:47:09] <paulweb515> tomschindl: you're own product/.e4xmi?
[17:47:21] <tomschindl> yes
[17:47:34] <paulweb515> tomschindl: does you have any bindings?  They would have to be in the new location
[17:47:47] <tomschindl> no I wiped them out
[17:50:12] <tomschindl> I clear now everything and now I get
[17:50:12] <tomschindl> java.lang.NullPointerException
[17:50:12] <tomschindl> 	at org.eclipse.e4.workbench.ui.internal.E4CommandProcessor.processCommands(E4CommandProcessor.java:51)
[17:50:12] <rcjsuen> isn't that the same one we had yesterday
[17:50:12] <tomschindl> ok that was because of not having ds in my launch config
[17:50:12] <tomschindl> ok and now I'm back with original exception
[17:51:09] <paulweb515> tomschindl: do I need emf.editor and emf.ui ?
[17:51:53] <tomschindl> to launch the standalone you need editor and ui
[17:52:03] <tomschindl> editor is the e4-app
[17:52:20] <paulweb515> tomschindl: and that's what you are running when you get this problem?
[17:52:22] <tomschindl> and ui can be used everywhere (also in 3.x)
[17:52:40] <tomschindl> yes I run the product in emf.editor
[17:53:07] *** kartben has quit IRC
[17:54:59] <tomschindl> paulweb515: I've now updated the ModelEditor.product to launch the application with the exception
[17:55:23] <tomschindl> is the BindingTableManager an OSGI-Service?
[17:55:54] <paulweb515> No, it's provided as part of the E4Workbench
[17:57:11] <tomschindl> let me try to resync once more
[17:59:19] <paulweb515> I get the errors as well, java.lang.IllegalArgumentException: Unable to find value for "org.eclipse.e4.ui.bindings.internal.BindingTableManager"
[17:59:19] <paulweb515> 	at org.eclipse.e4.core.services.internal.context.InjectionAbstract.getValue(InjectionAbstract.java:87)
[17:59:30] <paulweb515> Then an java.lang.NullPointerException
[17:59:30] <paulweb515> 	at org.eclipse.e4.ui.bindings.internal.BindingServiceImpl.getBestSequenceFor(BindingServiceImpl.java:155)
[18:00:04] <paulweb515> But they're both called after the initialization phase
[18:01:00] <paulweb515> maybe I'm not filling in a blank BindingManagerTable for no bindings (which is what you have) and that's causing all the problems
[18:01:13] <tomschindl> that could be
[18:03:58] <paulweb515> tomschindl: I've checked in a change, could you try that?
[18:04:18] <tomschindl> yes
[18:04:23] <tomschindl> what to update?
[18:06:03] <paulweb515> tomschindl: /org.eclipse.e4.ui.workbench/src/org/eclipse/e4/workbench/ui/internal/E4CommandProcessor.java
[18:06:29] <tomschindl> now it works
[18:12:43] <tomschindl> but my editor is not opening any more :-(
[18:14:46] <paulweb515> rcjsuen: I tried tomschindl's e4 app and a new doesn't open the editor ... but I'm not seeing any errors
[18:15:04] <rcjsuen> Sorry, I haven't been following this convo
[18:15:05] <paulweb515> <?xml version="1.0" encoding="ASCII"?>
[18:15:05] <paulweb515> <application:Application xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:application="http://www.eclipse.org/ui/2008/UIModel" xmi:id="_uxlqkTBWEd-1BtAs0NxlSA" id="_uxlqkTBWEd-1BtAs0NxlSA"/>
[18:15:16] <paulweb515> It creates the empty file, but doesn't open the editor in the app
[18:15:35] <paulweb515> tomschindl: I'm getting a lot of Event Admin service is not available
[18:15:46] <paulweb515> tomschindl: if it's not really available, that would kill opening any new parts
[18:16:59] <tomschindl> I'm the problem myself
[18:17:10] <paulweb515> adding equinox.events fixed the warnings, but it still doesn't open
[18:17:13] <tomschindl> I produce an NPE because I changed ids in my model :-)
[18:17:19] <paulweb515> Ah, OK
[18:17:20] <tomschindl> yes I already did that locally
[18:17:45] <tomschindl> the strange thing is that I don't get the exception
[18:18:00] <tomschindl> it looks like the injector simply skips it
[18:19:07] <tomschindl> ok everything back to normal
[18:20:56] <rcjsuen> the injector does many strange things
[18:21:10] <rcjsuen> Like the Maker, it works in mysterious ways.
[18:37:00] *** briandealwis has quit IRC
[18:37:27] *** magnet_ has quit IRC
[18:50:08] *** kartben has joined #eclipse-e4
[19:28:39] *** tomschindl has quit IRC
[19:42:01] *** kartben has quit IRC
[20:07:27] *** emoffatt has quit IRC
[20:34:43] *** susanmccourt has joined #eclipse-e4
[20:43:48] *** emoffatt has joined #eclipse-e4
[20:45:04] <emoffatt> rcjsuen: it appears that on any restart where you don't clear the WS the 'New' menu doesn't work
[20:46:05] <emoffatt> I thought it was the result of the 'Install new software...' messing with the system but a simple start empty, select a new view close, restart gets us to the same point
[20:46:52] <rcjsuen> I see it here too
[20:59:06] *** rcjsuen has quit IRC
[21:13:07] *** vogella has joined #eclipse-e4
[21:13:28] <vogella> This there a wiki page for "Model Components"?
[21:17:11] *** fsteeg has joined #eclipse-e4
[21:43:34] *** rcjsuen has joined #eclipse-e4
[21:47:57] <vogella> Anyone have a example their a view is directly contributed to the UI via a model component? In my example http://www.vogella.de/articles/EclipseE4/article.html#contribute_overview I have to add it via a command.
[21:48:48] <vogella> Tom Schindl suggested that I contribute a part instead of a part descriptor. What would be the right tag to use for a part?
[21:49:19] <vogella> I currently use <descriptors> which I assume from Toms comment that this related to a part descriptor.
[22:04:37] *** tjwatson has quit IRC
[22:15:29] *** kartben has joined #eclipse-e4
[22:28:13] *** DanRubel has quit IRC
[23:02:55] *** briandealwis has joined #eclipse-e4
[23:36:25] <paulweb515_1> vogella: wouldn't you use something similar to <children xsi:type="application:Part" xmi:id="_AXU5V-8IEd6FC9cDb6iV7g" id="_AXU5V-8IEd6FC9cDb6iV7g" URI="platform:/plugin/org.eclipse.e4.demo.e4photo/org.eclipse.e4.demo.e4photo.Location" label="Location"/> ?
[23:36:46] <paulweb515_1> vogella: that's if you want to simply place a part in a application:PartStack
[23:37:08] <paulweb515_1> vogella: adding descriptors is if you want it to be a view that can appear and disappear (via showView)
[23:45:16] <vogella> Big aha effect for me. Thanks a lot Paul. Now I get it. Model components works similar to Application.e4xmi. Only descriptors are special.
[23:45:45] <vogella> paulweb515_1: Works like a charm. Thanks again.
[23:55:38] *** kartben has quit IRC

top