[00:00:13] *** jam2 has quit IRC
[00:00:18] *** jam2 has joined #chromium
[00:00:29] *** dracflamloc has quit IRC
[00:01:34] <huanr> willchan: reliability bot failed http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Reliability/builds/8705/steps/reliability:%20partial%20result%20of%20current%20build/logs/stdio
[00:01:57] <huanr> I don't know who else to blame in this check in window: http://build.chromium.org/buildbot/perf/dashboard/ui/changelog.html?url=/trunk/src&range=40293:40299&mode=html
[00:02:08] <jamesr> hey git peoples, how does my git.chromium.org clone know to ignore base/ and all the other directories that gclient pulls in? is there some exclude filter set somewhere?
[00:03:23] <dpranke> jamesr: ?
[00:03:51] <dpranke> jamesr: I don't know
[00:03:56] <jamesr> evmar_afk: ^^ ?
[00:04:31] <akalin> .gitignore?
[00:04:50] <akalin> isn't base/ in git, too, though?
[00:05:19] <jamesr> oh yeah
[00:05:25] <jamesr> mystery solved :)
[00:05:33] <akalin> ^_^
[00:09:00] <huanr> willchan: I found the crash in reliability bot is a known issue
[00:09:07] <jhawkins> nsylvain: do we control the chromium builders on webkit?
[00:10:13] <willchan> huanr: excellent
[00:10:45] *** kuchhal has left #chromium
[00:11:33] *** MikeSmithW3C has quit IRC
[00:11:49] <leiz> rsesek: seems some win trybots are borked, i.e. codf217, codf178, but others work, i.e. jega194
[00:11:57] <nsylvain> jhawkins: sort of. why?
[00:12:10] <jhawkins> nsylvain: the mac chromium release bot needs an svn cleanup
[00:12:14] <rsesek> leiz: yea. I'm trying compiling by flipping disable_nacl to 1 in src/build/common.gypi
[00:12:23] <leiz> rsesek: that may not help
[00:12:25] <nsylvain> jhawkins: ok, i'll try to find someone for that
[00:12:31] <jhawkins> nsylvain: thanks!
[00:12:52] <rsesek> leiz: I'm desperate at this point. my CL touches windows code but I do not own a copy of Windows ? the trybots are my only recourse
[00:13:42] <leiz> rsesek: I hit this problem locally on my win bot, but flipping the bit didn't seem to help. But maybe it's because I didn't rerun gyp afterwards? It was a couple weeks ago and I don't remember.
[00:14:07] <rsesek> leiz: it's making more progress than previous try attempts, so I'll wait and see
[00:15:50] *** rafaelw1 has joined #chromium
[00:16:44] *** rafaelw has quit IRC
[00:16:49] *** MikeSmithW3C has joined #chromium
[00:19:07] *** Bleak has joined #chromium
[00:20:40] <rsesek> leiz: it appears to have worked
[00:21:05] *** cst has quit IRC
[00:23:13] *** selckin has quit IRC
[00:27:06] <nsylvain> jhawkins: let me know if it still causes problem. i dont usually monitor this webkit.org waterfall
[00:28:03] <jhawkins> nsylvain: ok, thanks!
[00:28:16] <jhawkins> I think it was just a hickup as a result of a server fail for googleurl
[00:28:34] <nsylvain> ok
[00:28:54] <pinkerton> i'm out, l8r all
[00:28:57] *** pinkerton has quit IRC
[00:29:31] *** paul_irish has quit IRC
[00:29:50] <leiz> sigh, I think the new valgrind errors are from r40304
[00:31:34] *** tittiatcoke has quit IRC
[00:35:45] <cira_mac> huanr: it seems we reverted valid CL (georgey). I'll re-revert
[00:36:19] *** romainhuet has quit IRC
[00:37:28] <huanr> cira_mac: it looks like a flaky test there
[00:38:05] *** oshima_ has quit IRC
[00:39:32] *** rohitrao has quit IRC
[00:40:04] <jamesr> why does base depend on nss?
[00:41:34] <leiz> jamesr: because of base/nss_util.h ?
[00:42:18] <jamesr> why's that in base, though?
[00:42:35] *** rafaelw1 has quit IRC
[00:42:46] <skrul> is there anyone here that can have a look at the windows try bots?  they seem to be angry
[00:43:19] *** erikkay has quit IRC
[00:43:40] *** lantizia has joined #chromium
[00:44:39] <leiz> skrul: email chromium-dev? lots of people are complaining about it
[00:46:47] <thakis> skrul / leiz: i think you're supposed to reply to the "try failed" email instead
[00:47:02] <thakis> and say "mr tryserver, dude, there's something not quite right with you"
[00:47:03] <rsesek> thakis: it's been like this since apparently last week
[00:47:16] <thakis> rsesek: yes?i think the nacl build or something like that is to blame
[00:47:20] <rsesek> yes
[00:47:23] <thakis> rsesek: maruel said something about disabling it
[00:47:33] <thakis> in any case, he's aware of the problem
[00:47:42] <rsesek> I flipped disable_nacl to 1 in src/build/common.gypi and my try job passed the compile step
[00:47:45] <leiz> thakis: I did, last week
[00:47:48] * jamesr thinks it's unfortunate how many dependencies base/ has. it makes it mostly useless to use as a generic library
[00:48:51] <huanr> fbarchard: compilation failed
[00:48:59] <akalin> that is pretty unfortunate
[00:49:04] <akalin> base shouldn't have any dependencies :|
[00:49:07] *** oshima_ has joined #chromium
[00:49:32] <skrul> leiz: i emailed the master of the trybots, said it is being fixed: http://codereview.chromium.org/660314
[00:49:40] <fbarchard> huanr: looking into it
[00:50:59] <jamesr> to use base (as in have a dependency on base.gyp:base) you have to map in: nss, nspr, icu, modp_b64 and sqlite, define a few gyp overrides ('library', 'target_arch', and a platform-specific 'nacl_*_defines' variable, and (on windows anyway) copy output_dll_copy.rules into a directory called build/ in order to be able to generate the project files and open them without error
[00:51:38] <jamesr> you also have to map in gmock/gtest
[00:54:25] *** jamesr has quit IRC
[00:54:50] <akalin> hmm
[00:54:57] <akalin> are all these third-party librarie?
[00:54:58] <akalin> s?
[00:55:52] <fbarchard> huanr: i found the problem.  It'll take 2 commits to fix
[00:56:03] *** dmaclach has quit IRC
[00:58:04] <huanr> In that case I prefer revert as it is really rush hour of the build right now, unless you are absolutely certain
[00:58:28] <fbarchard> patch 1 is in
[00:59:49] *** agl has joined #chromium
[00:59:52] <fbarchard> huanr: patch2 is in.
[00:59:58] <huanr> ok
[01:00:28] <huanr> let's open the tree as soon as the compilation passes
[01:01:52] <fbarchard> CL40324 and 40325.  The issue was ff_old_dirac_codec still referred to in oggdec.c
[01:03:56] *** slightlyoff has joined #chromium
[01:03:56] *** ChanServ sets mode: +v slightlyoff
[01:05:51] *** agl has quit IRC
[01:06:00] *** peloverde has joined #chromium
[01:13:21] *** lilmatt has joined #chromium
[01:13:54] <huanr> cira/fbarchard: good enough to open tree now?
[01:14:31] *** jweyrich has joined #chromium
[01:15:27] <fbarchard> arm seems to still have an old build... i think it will go green eventually
[01:16:10] *** asargent has joined #chromium
[01:16:10] *** ChanServ sets mode: +v asargent
[01:16:53] <fbarchard> huanr: lgtm
[01:17:42] *** RT|Chatzilla has joined #chromium
[01:18:56] *** jweyrich has joined #chromium
[01:19:06] <cira_mac> lgtm
[01:21:41] *** davemoore_ has joined #chromium
[01:21:57] <leiz> i talked to zork on gchat, he's working on the valgrind unit test memory leak
[01:24:37] *** dracflamloc has joined #chromium
[01:25:16] *** davemoore_ has quit IRC
[01:26:02] *** wyck has quit IRC
[01:26:09] *** wyck has joined #chromium
[01:26:37] *** jarsen has quit IRC
[01:26:57] *** agl has joined #chromium
[01:27:26] *** up365 has quit IRC
[01:29:33] *** jamesr has joined #chromium
[01:30:00] *** agl has quit IRC
[01:31:39] *** peloverde has quit IRC
[01:34:51] *** dglazkov has quit IRC
[01:36:57] *** jweyrich has quit IRC
[01:40:56] *** up365 has joined #chromium
[01:43:00] *** cbentzel has joined #chromium
[01:45:19] *** peloverde has joined #chromium
[01:46:23] *** up365 has quit IRC
[01:54:25] <jhawkins> cira_mac, huanr: grd change checked in, might have to clobber
[01:55:16] *** cbentzel has quit IRC
[01:56:02] *** up365 has joined #chromium
[01:57:01] *** up365 has quit IRC
[01:57:19] *** ukai_ has joined #chromium
[01:58:46] *** up365 has joined #chromium
[01:59:04] *** snej has quit IRC
[02:02:38] *** mazda has joined #chromium
[02:03:09] *** wyck has quit IRC
[02:03:42] *** wyck has joined #chromium
[02:04:30] *** zyichi has joined #chromium
[02:08:01] *** rafaelw has joined #chromium
[02:08:17] *** wyck has quit IRC
[02:19:43] *** bent-mozilla has quit IRC
[02:19:43] <Thell> is it expected to have visual studio bring up the conversion wizard even when GYP_MSVS_VERSION = 2008 was set as an env var?
[02:20:14] <akalin> that doesn't sound right
[02:20:35] <maruel> Thell: RTM
[02:22:52] *** peloverde has left #chromium
[02:23:58] *** erikkay has joined #chromium
[02:24:11] *** tedoc2000 has quit IRC
[02:24:45] *** hbono has joined #chromium
[02:27:14] *** erikkay has quit IRC
[02:27:32] *** trungl_mbp has quit IRC
[02:27:49] *** asargent has quit IRC
[02:27:53] *** eseidel_ has joined #chromium
[02:28:03] *** eseidel__ has joined #chromium
[02:29:09] * Thell looks at maruel
[02:29:27] * Thell sighs
[02:29:34] * Thell goes back to the drawing board
[02:31:23] *** ukai_ has quit IRC
[02:32:26] *** eseidel_ has quit IRC
[02:34:03] *** bweinstein has quit IRC
[02:34:05] *** jrmuizel has quit IRC
[02:34:20] *** lisppaste9 has quit IRC
[02:35:35] *** fqian_ has quit IRC
[02:39:40] *** trungl_mbp has joined #chromium
[02:40:51] *** rsteiner has joined #chromium
[02:42:23] *** bweinstein has joined #chromium
[02:42:27] <zyichi> xmlrpc
[02:42:49] <maruel> this word hurts
[02:43:21] <akalin> what is going on in here
[02:43:39] *** trungl_mbp is now known as trungl
[02:43:41] *** ChanServ sets mode: +v trungl
[02:45:16] *** lisppaste9 has joined #chromium
[02:49:32] *** thakis has quit IRC
[02:53:11] *** BeZerk has quit IRC
[02:53:12] *** lantizia has quit IRC
[02:53:44] *** quaelin has quit IRC
[02:54:40] *** BeZerk has joined #chromium
[02:58:25] *** pamg has quit IRC
[03:00:09] *** wyck has joined #chromium
[03:00:54] *** wyck has quit IRC
[03:02:20] *** stuartmorgan has quit IRC
[03:02:43] *** dave_levin has quit IRC
[03:02:57] *** feldstein has quit IRC
[03:04:17] *** lxp121 has quit IRC
[03:12:30] *** mrossetti has quit IRC
[03:14:25] <rubenbb> sup pval, you wanted to know my nick in here
[03:14:51] *** Venom_X has quit IRC
[03:14:58] <rubenbb> btw, there is a file_version_info_linux.cc, that we use on BSD, so that's what caused the problem
[03:17:00] *** Manatsu has quit IRC
[03:18:56] *** rsesek has quit IRC
[03:19:34] *** trungl has quit IRC
[03:23:23] <pval> hey... i see the file_version_*linux*, aha!
[03:23:39] <pval> i hate how subtle these gyp bugs are :)
[03:25:31] *** dracflamloc has quit IRC
[03:26:05] *** slightlyoff has quit IRC
[03:26:35] <pval> it's kinda ugly we are compiling all of these _linux files on BSD (and probably Solaris?), should rename them to _posix eventually
[03:27:02] <rubenbb> yeah, but works for now as we mostly use the same functionality
[03:27:02] <akalin> OS X is posix, too
[03:27:13] <akalin> perhaps _non_os_x_posix :)
[03:27:35] <pval> well OS X is special cased almost everywhere already.
[03:28:28] <rubenbb> the problem is the OS X define refers to both its posix apis and cocoa, but cocoa isn't on posix
[03:28:39] <rubenbb> so for now os x != posix in chromium ;)
[03:30:28] <rubenbb> pval: PMed you
[03:33:27] <akalin> that's true
[03:33:31] *** TheFuzzball has joined #chromium
[03:33:42] <akalin> so the solution is to hunt down all the cases where OS_MACOSX actually means OS_POSIX and change it?
[03:34:09] *** roc has quit IRC
[03:35:50] *** rjkroege has quit IRC
[03:36:34] <rubenbb> well, there's a third case too, we don't use os_posix necessarily to refer to only the posix apis now, it simply refers to common unix behavior, nobody's actually reading the posix spec to make sure ;)
[03:36:47] <akalin> that is true
[03:36:59] <rubenbb> so to the extent that OS X differs from common unix behavior on those underlying issues, there might be some difference too
[03:37:31] <akalin> use java, problem solved
[03:37:33] <rubenbb> for example, OS X might have it's own shared memory implementation that the other unixes don't have.  I'm more speculating here as I'm not too familiar with those underlying APIs of OS X
[03:38:10] *** thomasvl has joined #chromium
[03:38:11] *** ChanServ sets mode: +v thomasvl
[03:41:32] *** oshima_ has quit IRC
[03:47:11] *** trungl_mbp has joined #chromium
[03:47:22] *** trungl_mbp is now known as trungl
[03:47:22] *** ChanServ sets mode: +v trungl
[03:48:41] *** leeight has joined #chromium
[03:50:27] *** leeight has left #chromium
[03:50:51] *** mpcomplete has quit IRC
[03:51:13] *** cbentzel has joined #chromium
[03:51:27] *** lnostdal has quit IRC
[03:52:22] *** btipling has joined #chromium
[03:52:22] *** btipling has joined #chromium
[03:52:52] *** rafaelw has left #chromium
[03:56:36] *** vIkSiT has joined #chromium
[03:58:18] *** roc has joined #chromium
[04:02:09] *** cbentzel has quit IRC
[04:07:43] *** thomasvl has quit IRC
[04:08:35] *** oshima_ has joined #chromium
[04:10:49] *** detaos has quit IRC
[04:16:24] *** thakis has joined #chromium
[04:16:25] *** ChanServ sets mode: +v thakis
[04:16:42] *** thakis_ has joined #chromium
[04:16:43] *** ChanServ sets mode: +v thakis_
[04:18:30] *** scherkus has quit IRC
[04:19:44] *** thakis__ has joined #chromium
[04:19:45] *** ChanServ sets mode: +v thakis__
[04:20:33] *** Bleak has quit IRC
[04:20:35] *** thakis has quit IRC
[04:20:36] *** thakis__ is now known as thakis
[04:23:09] *** thakis_ has quit IRC
[04:26:55] *** TheFuzzball has quit IRC
[04:28:08] *** mmoss has quit IRC
[04:32:25] *** up365 has quit IRC
[04:34:35] *** dpranke has quit IRC
[04:38:22] *** up365 has joined #chromium
[04:41:19] *** vIkSiT has quit IRC
[04:43:01] *** jamesr has quit IRC
[04:46:19] *** up365 has quit IRC
[04:52:38] *** oshima_ has left #chromium
[04:53:29] *** eseidel__ has quit IRC
[04:54:58] *** dglazkov has joined #chromium
[04:54:59] *** ChanServ sets mode: +v dglazkov
[05:00:48] *** dglazkov has quit IRC
[05:01:55] *** jamesr has joined #chromium
[05:04:41] *** jweyrich has joined #chromium
[05:04:42] *** up365 has joined #chromium
[05:09:26] *** dglazkov has joined #chromium
[05:09:27] *** ChanServ sets mode: +v dglazkov
[05:09:52] *** lnostdal has joined #chromium
[05:11:06] *** lilmatt has quit IRC
[05:14:43] *** aaron_liuj has joined #chromium
[05:14:59] <aaron_liuj> hi
[05:15:08] <aaron_liuj> everyone
[05:15:45] <aaron_liuj> gclient sync
[05:15:45] <aaron_liuj> Error: git version 1.6.0.4 < minimum required 1.6.6
[05:16:41] <trungl> upgrade your git?
[05:17:00] *** dmaclach has joined #chromium
[05:18:39] *** dracflamloc has joined #chromium
[05:20:04] *** lmaonade has joined #chromium
[05:20:15] <aaron_liuj> how to do that in the ubuntu
[05:21:08] *** jamesr has quit IRC
[05:21:38] <lmaonade> Hey guys, quick issue that I just came across: I'm running windows 7 (32 bit) and just installed chrome (5.0.335.1 dev), whenever I open links in new tabs, there's a high chance that the entire chrome browser freezes for a solid 2-3 seconds.
[05:21:44] <lmaonade> Anyone know of any fix for this?
[05:29:25] <rubenbb> aaron_liuj: if you don't know how to update git, maybe you shouldn't be building chromium from source?  there exist packages for chromium
[05:30:09] <rubenbb> lmaonade: I think if there was a known fix, it'd be fixed ;)
[05:30:24] <akalin> lmaonade: try the channel/forum in the topic
[05:30:43] <aaron_liuj> gclient sync
[05:30:49] <aaron_liuj> Error: git version 1.6.0.4 < minimum required 1.6.6
[05:31:38] <aaron_liuj> sudo apt-get install git
[05:31:52] <aaron_liuj> ......
[05:31:56] <aaron_liuj> Reading state information... Done
[05:31:56] <aaron_liuj> git is already the newest version.
[05:31:56] <aaron_liuj> 0 upgraded, 0 newly installed, 0 to remove and 270 not upgraded.
[05:31:58] <tony^work> aaron_liuj: what version of ubuntu are you using?
[05:32:02] <aaron_liuj> how to do that
[05:32:21] <aaron_liuj> 9.04
[05:33:06] <tony^work> I think you have 2 options: download and compile git yourself or upgrade to karmic/lucid
[05:33:32] <tony^work> there might be someone who provides a newer git package for 9.04, but I'm not sure
[05:33:52] <aaron_liuj> but how to do upgrade to karmic/lucid
[05:34:02] *** lmaonade has quit IRC
[05:34:11] <aaron_liuj> how to o do that
[05:34:21] <rubenbb> aaron_liuj: this is not an ubuntu support channel
[05:34:31] <tony^work> do a bing search for "how to upgrade to karmic"
[05:34:46] <rubenbb> bing it! ;)
[05:34:53] <rubenbb> lol
[05:34:54] <tony^work> rubenbb: exactly :)
[05:34:58] <akalin> duck duck go > bing
[05:37:15] *** hbono has quit IRC
[05:45:54] *** hbono has joined #chromium
[05:46:08] <rubenbb> I just ran some test searches today with google yahoo and bing, as I do a couple times a year to compare
[05:46:36] *** Sarten-X has quit IRC
[05:46:46] <rubenbb> bing sucks as usual but surprisingly yahoo seemed to have caught up with google on this small sample, not sure if they're using bing for search yet
[05:47:51] <rubenbb> would be extremely ironic if yahoo ditched their own search and adopted bing's inferior search right when their own got good :)
[05:50:55] *** jamesr has joined #chromium
[05:51:01] <thakis> trungl: spelling fodder! http://codereview.chromium.org/661354
[05:53:19] <akalin> that xib is pretty damn clean
[05:53:23] <akalin> :O
[05:53:45] *** Zucca has joined #chromium
[05:57:07] <rubenbb> hmm, nevermind, ran another search for a blog comment from two months ago, google and surprisingly bing had it while yahoo didn't.  Anyway, my samples are not very big
[06:06:23] *** fishd_ has joined #chromium
[06:06:23] *** ChanServ sets mode: +v fishd_
[06:07:35] *** fishd__ has joined #chromium
[06:07:35] *** ChanServ sets mode: +v fishd__
[06:08:09] *** skrul_ has joined #chromium
[06:08:13] <aaron_liuj> i want to upgrate in the 9.04 version
[06:08:29] *** MikeSmithW3C^ has joined #chromium
[06:08:40] <aaron_liuj> i want to upgrate git in the 9.04 version,how to do his
[06:08:55] *** fishd has quit IRC
[06:09:38] <aaron_liuj> ................
[06:09:39] <aaron_liuj> git is already the newest version.
[06:09:40] <aaron_liuj> 0 upgraded, 0 newly installed, 0 to remove and 270 not upgraded.
[06:09:51] <rubenbb> aaron_liuj: http://www.google.com/search?q=git+9.04
[06:10:57] *** jlouie has quit IRC
[06:11:00] *** fishd_ has quit IRC
[06:11:13] <trungl> or http://lmgtfy.com/?q=git+9.04
[06:11:30] * trungl wonders why there isn't a lmbtfy.com
[06:11:43] *** MikeSmithW3C has quit IRC
[06:13:33] *** pamg has joined #chromium
[06:13:34] *** ChanServ sets mode: +v pamg
[06:19:31] *** Sarten-X has joined #chromium
[06:19:51] *** sundiamonde has quit IRC
[06:20:02] *** jlouie has joined #chromium
[06:20:56] <thakis> trungl: http://5z8.info/hackwebcam_y6h6y_autoinstall
[06:21:54] <trungl> it's not quite so demonstrative
[06:22:31] <thakis> trungl: http://images.google.com/images?q=thanks%20for%20the%20review i love the dude in the top row
[06:23:04] <Thell> darn... 4 hours of building and there is build error :/  atlbase.h... really?  I had no idea atl was a requirement.
[06:23:57] <thakis> Thell: i think the wiki says you need the some specific msvc version, and that version comes with atl
[06:24:06] <thakis> Thell: there's a way to get atl for free though iirc
[06:24:14] <trungl> thakis: which dude? which row he's on depends on window size, apparently
[06:24:42] <thakis> trungl: http://api.ning.com/files/bkw5XiqS-MR3azWR6DA2DBko-1SETsJqTCeF*bGrUHQCG524bArsTHm0iu5hnr4CHUxjZJQYa6B4iQw8-7LK*0JOj5G4Fh2Y/Avatar7.jpg
[06:25:05] <trungl> heh
[06:25:23] <Thell> thakis: Well, I have atl installed, I just purposefully don't keep it active in my path to ensure I don't accidently work with OSS with ATL depends
[06:26:10] <Thell> And I sure don't recall seeing that in a requirements list anywhere (though I could easily have missed it)
[06:27:00] <Thell> nothing on here about it:: http://dev.chromium.org/developers/how-tos/build-instructions-windows#TOC-Building-Chromium
[06:28:28] <trungl> I would have thought that the Visual Studio requirement was a bigger impediment.
[06:28:33] * trungl shrugs.
[06:28:38] <rubenbb> I smell an ATL rant coming ;)
[06:28:56] <Thell> nah, not from me
[06:29:19] <trungl> clearly we should get it building with mingw
[06:29:52] <Thell> interesting though, the only thing I really see mentioned there is the win7 sdk.  Which is installed and registered.
[06:30:26] <rubenbb> why do you avoid OSS with ATL depends?
[06:30:56] *** kwinz2 has quit IRC
[06:31:07] <Thell> ATL is easily available to most people and isn't freely distributable from what I know
[06:31:30] <Thell> By easily avail, I mean not jumping through hoops with different older sdks and path configs in VS
[06:31:54] <rubenbb> I don't see the problem
[06:32:44] <Thell> there isn't for a project that makes it known there is a dependency there ;)
[06:33:25] <Thell> after 4 hours of building though it is kind of a let down...
[06:33:32] <rubenbb> I'm sure somebody here could add the dependency to the list
[06:34:17] *** Zucca has quit IRC
[06:34:21] <Thell> I wonder just how many people would think a FOSS project of this scale having a ATL dpendency would be considered 'unexpected'.
[06:34:24] * Thell shrugs
[06:34:52] <trungl> It's not required for other platforms.
[06:35:19] <trungl> And since, on Windows, it requires VS anyway....
[06:35:35] <rubenbb> oh, did you mean ATL "isn't easily available"?
[06:36:09] <trungl> It's easily available for those with a credit card. :P
[06:36:10] *** pamg has quit IRC
[06:36:27] <Thell> hmmm... I'm guessing there a quite a few OSS 'fan' devs out there who use Express editions instead of the full editions
[06:37:21] *** magn3ts has joined #chromium
[06:37:25] <Thell> Well, ATL/MFC is available if you install the correct version of the SDK  (2003 iirc), then add the path to the express edition's path.
[06:37:46] <trungl> The dependency on ATL is small, IIRC. Someone did make some effort at getting it to build with the express edition some time ago, but I don't know what happened to that effort.
[06:37:58] <Thell> If you do that hough you need to be aware of how it affects the other SDK packages installed.
[06:38:43] *** zaheer_ has joined #chromium
[06:39:20] <trungl> http://cotsog.wordpress.com/2009/11/08/how-to-compile-google-chrome-with-visual-c-2008-express-edition/
[06:39:25] <Thell> Personally I have VS 05 full, VS 08 express, and 2010 RC full installed so access to ATL _isn't_ an issue.  If I had known I would've built with VS 05 instead of 08 though.
[06:39:36] <thakis> yay, i broke the tree
[06:39:44] *** zaheer_ has quit IRC
[06:39:57] *** zaheer_ has joined #chromium
[06:40:23] *** jweyrich has quit IRC
[06:40:39] * trungl claps.
[06:40:56] * trungl has said all along that it's all thakis's fault.
[06:41:01] <thakis> looks like a flake?
[06:41:04] <thakis> http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests/builds/224/steps/unit_tests/logs/stdio
[06:41:12] <trungl> Wow, since when did we have Mac10.6 tests?
[06:41:33] <Thell> trungl: yep, that post states just what I was stating re installing & setting up the ATL.  That should surely be on the wiki page.
[06:41:38] <thakis> pretty new?i think thomasvl wrote a mail about that?
[06:41:43] *** jamesr has quit IRC
[06:42:08] <thakis> akalin: is ProfileSyncServiceAutofillTest.HasNativeEmptySync a known flaky test?
[06:42:16] * trungl should read his email more carefully.
[06:42:57] <trungl> Thell: possibly, though build information bitrots even faster than code
[06:43:15] <Thell> true that!
[06:43:18] <trungl> we have enough trouble keeping up-to-date information for "supported" build configurations
[06:43:32] *** iisi50mhz has joined #chromium
[06:43:39] <thakis> fbarchard: a couple of video webkit tests went red. looks like your commit?
[06:43:51] *** magn3ts has quit IRC
[06:43:58] <chase> trungl: mac 10.6 bots were added on wed/thursday last week
[06:44:01] <Thell> Looks like quite a few projects have ATL depends though...  perhaps just a blip in the requirements section.  'ATL currently required.'
[06:44:17] <thakis> Thell: it says that somewhere
[06:44:32] <thakis> Thell: also, people are working to remove that dependency i believe
[06:44:40] <Thell> Not on the 'building on windows' page.
[06:44:52] <Thell> Yeah I see the commits regarding removing ATL depends
[06:44:55] * Thell claps
[06:45:11] <fbarchard> thakis: possible... i'm patching ffmpeg, but its supposed to be just security fixes
[06:45:37] <thakis> fbarchard: looks like the webkit video tests don't appreciate security
[06:46:12] <fbarchard> 40363 was simply a roll.  guess we should go back for now
[06:46:17] *** fqian_ has joined #chromium
[06:46:27] <thakis> fbarchard: cool, thanks
[06:46:36] *** iisi50mhz has quit IRC
[06:47:08] <thakis> trungl: ping in gtalk
[06:47:21] <trungl> thakis: ack in gtalk
[06:47:45] <thakis> trungl: thanks!
[06:48:11] *** bweinstein has quit IRC
[06:49:38] <thakis> trungl: ok, enough gtalk
[06:50:14] *** thakis_ has joined #chromium
[06:50:14] *** ChanServ sets mode: +v thakis_
[06:50:16] <fbarchard> 40365 rolls back to  "ffmpeg_revision": "40324",
[06:53:54] *** thakis has quit IRC
[06:53:54] *** thakis_ is now known as thakis
[06:54:13] *** fbarchard has left #chromium
[06:55:08] <Thell> OK... I see now where that link was linked in the build-instructions-windows.  I propose it is changed from:
[06:55:10] <Thell> Microsoft Visual Studio 2005 Standard/Pro (8.0) or later. Visual Studio Express may work if you have enough free time. Visual Studio 2005 Team trial seems to work.  Please tell us if Visual Studio 2008 Pro Trial works. Visual Studio 2010 Beta 2 won't work.
[06:55:17] *** dracflamloc has quit IRC
[06:55:47] <Thell> Where [Visual Studio Express] is shown as the linked uri
[06:55:49] *** pfeldman has joined #chromium
[06:56:08] <Thell> to [This post] details how Visual Studio Express may work....
[06:57:01] <Thell> I just skipped over that link thinking it went to the free version of VS currently acive for Windows
[06:57:31] <Thell> Is that acceptable?
[06:59:13] *** dmaclach has quit IRC
[07:00:40] <Thell> FYI: I would've still skipped over it if it had not been for trungle's earlier statement, a google search for inurl:chromium +atl, and  msg #00581 on chromium-dev stating the link had been added
[07:01:09] <Thell> I'm not trying to harp here... just wasting time until this building stops...
[07:02:20] *** roc has quit IRC
[07:02:41] *** huanr has quit IRC
[07:03:28] *** bers has joined #chromium
[07:06:26] <thakis> Thell: if you give me the url to the page you're talking about, i'll change it
[07:06:50] <Thell> thakis
[07:06:52] <Thell> http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows#TOC-Prerequisite-software
[07:06:58] <Thell> Bullet point 2
[07:07:04] <Thell> second sentence
[07:08:42] <Thell> Actually I guess the most direct thing to state would be VC 8 with ATL is required. :P  But that's not quite as user friendly I guess.
[07:09:39] <thakis> Thell: done
[07:09:52] *** Mavericks has joined #chromium
[07:10:15] <Thell> Excellent, thank you
[07:10:30] *** abarth has joined #chromium
[07:10:30] *** ChanServ sets mode: +v abarth
[07:10:32] <Thell> Hopefully that saves someone else some pain someday
[07:11:29] <Mavericks> interesting chrome rendering with nearly 5 windows and more than 100 tabs in a window - tinypic.com/r/9tln6e/6
[07:12:29] *** btipling has quit IRC
[07:14:21] <Thell> WTF?  I don't know that I'd call that 'interesting' lol
[07:14:36] *** fqian_ has quit IRC
[07:16:08] <Mavericks> Thell: of course, not necessary interesting for every body ;)
[07:16:09] <rubenbb> all I see is a bunch of blurs
[07:17:36] <Thell> that's all I see too, that is the point though, yes?
[07:17:37] <rubenbb> is this one of those magic eye type things, where you can see the tabs if you squint right?  I never could see those ;)
[07:17:49] <Thell> HA!
[07:18:06] <Thell> LSDBrowser alpha
[07:18:21] <rubenbb> I'm waiting for flockrium :D
[07:21:39] *** thakis_ has joined #chromium
[07:21:39] *** ChanServ sets mode: +v thakis_
[07:22:16] *** thakis_ has quit IRC
[07:22:20] <rubenbb> oh wait, that should be flockmium, my bad :)
[07:23:54] *** bers has quit IRC
[07:24:36] *** thakis has quit IRC
[07:25:29] *** fqian_ has joined #chromium
[07:25:51] *** thakis has joined #chromium
[07:25:52] *** ChanServ sets mode: +v thakis
[07:28:56] <Thell> :)
[07:29:32] <Thell> goog night guys... this could be building till morning...  1.5Ghz && 1.5GB ram
[07:29:35] <Thell> have fun
[07:32:05] *** acon has joined #chromium
[07:32:31] *** dglazkov has quit IRC
[07:35:32] *** Thell has quit IRC
[07:37:57] *** phajdan-1r|afk has quit IRC
[07:38:20] *** dracflamloc has joined #chromium
[07:38:22] <rubenbb> hmm, probably not a good idea for me to encourage h.264 use by distributing chromium builds with it enabled, will remove that in the next build
[07:38:57] *** fqian_ has quit IRC
[07:44:22] *** thakis has quit IRC
[07:46:42] *** firestrider has joined #chromium
[07:50:13] *** acon has quit IRC
[07:59:02] *** systemIX has quit IRC
[08:00:38] *** dracflamloc has quit IRC
[08:06:29] *** michaeln has quit IRC
[08:08:49] *** jlouie has quit IRC
[08:09:19] *** firestrider has quit IRC
[08:09:42] *** pfeldman has quit IRC
[08:19:58] *** roc has joined #chromium
[08:21:36] *** kwinz2 has joined #chromium
[08:22:15] *** fishd__ has quit IRC
[08:28:52] *** phajdan-jr|afk has joined #chromium
[08:28:52] *** ChanServ sets mode: +v phajdan-jr|afk
[08:32:28] *** bweinstein has joined #chromium
[08:35:57] *** Mavericks has quit IRC
[08:37:12] <aaron_liuj> who compile the chorme for arm platform ?
[08:41:28] *** bweinstein has quit IRC
[08:51:09] *** magn3ts has joined #chromium
[09:01:30] *** abarth has quit IRC
[09:01:51] *** ukai_ has joined #chromium
[09:05:38] *** shenki has quit IRC
[09:19:30] *** ukai_ has quit IRC
[09:24:00] *** tittiatcoke has joined #chromium
[09:27:38] *** roc has quit IRC
[09:31:38] *** roc has joined #chromium
[09:37:08] *** GPenguin has joined #chromium
[09:41:19] *** romainhuet has joined #chromium
[09:41:29] <aaron_liuj> who have compiled chrome for arm platform  successufully ?
[09:42:45] <jochen__> it's compiled as part of our continuous build
[09:42:50] <jochen__> do you have a specific problem with arm?
[09:45:59] *** phajdan-jr|afk is now known as phajdan-jr
[09:48:00] <aaron_liuj> i down know hot to do
[09:48:26] <aaron_liuj> i down know how to do  this
[09:49:10] <aaron_liuj> where i can find the docs for compiling chrome for arm
[09:50:50] *** tbassetto has joined #chromium
[09:50:58] <tony^work> aaron_liuj: when I do a search for "chromium arm", the first hit is a page describing how to build chromium for arm
[09:54:18] <aaron_liuj> i have try to do that ,but it's say too simple for me so i could not  compile whole still
[09:56:33] <rubenbb> phajdan-jr: any update on build source tarballs?
[09:59:26] <phajdan-jr> rubenbb: should be good, last tests with nsylvain
[10:03:03] <aaron_liuj> when i gclient sync
[10:03:14] <aaron_liuj> Initialized empty Git repository in /home/aaron/tcc/LINUX_APP_v1.300_2009_11_04/Project/chromiumos/chromiumos.git/.git/
[10:03:48] <aaron_liuj> it take so much time ,and has not any putout
[10:08:14] *** magn3ts has quit IRC
[10:09:47] *** phajdan-jr is now known as phajdan-jr|afk
[10:13:26] *** phajdan-jr|afk is now known as phajdan-jr
[10:16:27] *** Twey has quit IRC
[10:16:28] <jochen__> aaron_liuj: chromium os?
[10:26:36] *** tittiatcoke has quit IRC
[10:26:50] *** tittiatcoke has joined #chromium
[10:30:25] *** shenki has joined #chromium
[10:31:47] *** AngryKoala has joined #chromium
[10:40:59] *** zerwas has joined #chromium
[10:47:05] *** loislo has quit IRC
[10:49:12] *** ukai_ has joined #chromium
[10:49:23] *** ukai_ has quit IRC
[10:49:45] *** ukai_ has joined #chromium
[10:54:39] *** Arc__ has joined #chromium
[11:00:30] *** hbono has quit IRC
[11:07:09] *** holdenss has joined #chromium
[11:11:48] *** General1337 has joined #chromium
[11:12:07] *** Arc__ has left #chromium
[11:13:21] *** GPenguin has left #chromium
[11:13:29] *** andrix has joined #chromium
[11:15:18] *** General13372 has quit IRC
[11:20:06] *** ROBOd has joined #chromium
[11:22:32] <aaron_liuj> i just want chromium
[11:23:02] *** AngryKoala has quit IRC
[11:28:21] *** ukai_ has quit IRC
[11:34:40] *** andrix1 has joined #chromium
[11:35:57] *** andrix has quit IRC
[11:38:33] *** raouldlv has joined #chromium
[11:38:50] *** raouldlv has left #chromium
[11:55:33] *** praseodym has quit IRC
[11:59:20] *** ROBOd has quit IRC
[12:00:28] *** ROBOd has joined #chromium
[12:08:25] *** MikeSmithXX has joined #chromium
[12:11:59] *** MikeSmithW3C^ has quit IRC
[12:12:12] *** phajdan-jr has quit IRC
[12:13:35] *** Manatsu has joined #chromium
[12:14:13] *** phajdan-jr has joined #chromium
[12:14:14] *** ChanServ sets mode: +v phajdan-jr
[12:45:22] *** kwinz2 has quit IRC
[12:46:24] *** mazda has quit IRC
[12:47:07] *** Michelangelo has joined #chromium
[12:58:22] *** selckin has joined #chromium
[12:58:40] *** kwinz2 has joined #chromium
[13:07:56] <aaron_liuj> AM_GLIB_GNU_GETTEXT: command not found
[13:17:12] *** GabydeWilde_ has quit IRC
[13:18:08] *** Michelangelo has quit IRC
[13:21:54] *** GabydeWilde_ has joined #chromium
[13:25:10] *** yurys has joined #chromium
[13:30:54] *** takuan has joined #chromium
[13:31:40] <takuan> is there a way to disable the sounds chromium makes when clicking buttons?
[13:33:21] <takuan> i'm on ubuntu btw
[13:46:59] *** zyichi has quit IRC
[13:49:19] *** holdenss has quit IRC
[13:49:34] *** zyichi has joined #chromium
[13:55:08] *** phajdan-jr has quit IRC
[13:55:26] *** ejpbruel has joined #chromium
[13:55:43] *** phajdan-jr has joined #chromium
[13:55:44] *** ChanServ sets mode: +v phajdan-jr
[13:56:27] <ejpbruel> anybody here ever tried to get v8 to work with coroutines/fibers?
[13:57:00] <ejpbruel> i wrote a simple proof of concept using makecontext/swapcontext, but v8 seem to get confused when i call a function object from anywhere but the thread context in which I initialized it
[13:57:31] *** zyichi has left #chromium
[14:05:27] *** kwinz2 has quit IRC
[14:06:45] *** takuan has left #chromium
[14:08:03] *** btipling has joined #chromium
[14:08:03] *** btipling has joined #chromium
[14:10:24] *** anajo has quit IRC
[14:10:28] *** anajo has joined #chromium
[14:10:56] *** pfeldman has joined #chromium
[14:11:52] *** pkaddi has joined #chromium
[14:12:25] *** rsteiner has quit IRC
[14:12:49] *** taf2 has joined #chromium
[14:16:21] <phajdan-jr> ejpbruel: try rather #v8 and their MLs
[14:16:31] <phajdan-jr> sounds interesting btw
[14:18:27] *** rsesek has joined #chromium
[14:18:58] *** kwinz2 has joined #chromium
[14:20:22] <ejpbruel> @phajdan-jr thank your for the tip, ill try it over there
[14:21:34] *** luke_ has joined #chromium
[14:31:39] <ejpbruel> @pahjdan-jr #v8 seems to be used only for commit messages
[14:37:45] <phajdan-jr> ejpbruel: try the MLs then
[14:37:58] <phajdan-jr> phajdan-jr: and note that most of the v8 team is in Denmark
[14:38:13] <ejpbruel> yes, i know :)
[14:38:36] *** scottmattocks has joined #chromium
[14:38:43] <ejpbruel> I'm in Europe myself
[14:38:51] <ejpbruel> anyway, ive tried the ML's
[14:41:54] <maruel> ejpbruel: v8 is specifically not thread safe, I assume that rules out fibers too
[14:42:10] <ejpbruel> @marual not necessarily
[14:42:10] <maruel> fibers are the worst implementation of coroutine possible anyway
[14:42:43] <jorlow> ejpbruel: v8 uses a lot of globals
[14:42:50] <jorlow> and there was a project to get rid of such use
[14:42:55] <jorlow> and it essentially failed
[14:42:59] <ejpbruel> @jorlow rly? thats intersting
[14:43:16] <ejpbruel> any references on that? i need to come up with a feasibility report on this
[14:43:39] <jorlow> sorry, but no
[14:43:44] <ejpbruel> the idea I had was that since fibers are non-preemptive, with careful scheduling race conditions should not occur, so it might still work despite the presence of globals
[14:43:59] <jorlow> i just no that for a while they wanted to get multiple workers working in the same process with multiple threads
[14:44:01] <ejpbruel> @jorlow thats alright, thanks anyway :)
[14:44:03] <jorlow> it was on the todo list for a while
[14:44:08] <jorlow> they tried for a while
[14:44:17] <jorlow> and decided it wasn't worth te effort
[14:44:41] *** pinkerton has joined #chromium
[14:44:41] *** ChanServ sets mode: +v pinkerton
[14:44:47] <jorlow> but that's as muc as i know
[14:44:49] *** cbentzel has joined #chromium
[14:44:58] <maruel> ejpbruel: I still don't see the advantage of doing that, I'm curious
[14:46:04] <ejpbruel> @maruel, the idea is that when you encounter a call in javascript that would logically block, you would still be able to fiber switch to other blocking calls as soon as the file descriptor they are blocked on becomes ready
[14:46:36] <ejpbruel> you only need threads if you want shared memory AND multiple cores
[14:46:42] <ejpbruel> otherwise fibers will do the trick just fine
[14:46:50] *** awalker has joined #chromium
[14:46:50] *** ChanServ sets mode: +v awalker
[14:47:07] <maruel> ejpbruel: you know UMS? http://msdn.microsoft.com/en-us/library/dd627187.aspx
[14:47:32] <ejpbruel> no, i dont, i will look into that
[14:47:38] <ejpbruel> right now this is a linux only project tho
[14:47:42] <maruel> ejpbruel: the MS PMs were "excited" talking about this and how this was superious to fibers
[14:47:47] <maruel> ok
[14:47:52] <maruel> then please ignore UMS :)
[14:48:03] <ejpbruel> will do :)
[14:48:17] <maruel> Never realized there was fiber support on linux
[14:48:21] <ejpbruel> so, does anybody know a bit more about what state v8 has internally?
[14:48:25] *** awalker has left #chromium
[14:48:52] <maruel> ejpbruel: you know nodejs?
[14:49:19] <ejpbruel> @ejpbruel definitely, that's what im supposed to write an alternative for :D
[14:49:32] <ejpbruel> but obviously this is still in the R&D state
[14:49:54] <ejpbruel> would this ring any bells to you?
[14:50:04] <maruel> no
[14:50:20] <ejpbruel> when i call a function object from another thread context/fiber than the one i initialized v8
[14:50:30] <ejpbruel> it complains about Uncaught RangeError: Maximum call stack size exceeded
[14:50:47] <ejpbruel> so what jorlow suggests about v8 having a lot of global state would make sense
[14:50:50] <maruel> ejpbruel: yes, you want to hide the fact that you're calling sync calls to v8
[14:50:59] <maruel> but no bells about R&D projects
[14:51:17] <maruel> I think you can't without having multiple v8 global contexts
[14:51:25] <maruel> which won't scale
[14:51:25] *** CrazyRobot has joined #chromium
[14:51:29] <ejpbruel> no exactly
[14:52:57] <maruel> ejpbruel: "no exactly" or "not exactly" ?
[14:53:26] <ejpbruel> "no exactly", i think you are right :)
[14:53:32] <maruel> ok
[14:53:39] <ejpbruel> gimme a sec maruel, brb
[14:54:09] <maruel> jorlow: you know why they couldn't get rid of the globals? I'm not intimate with the v8 code
[14:55:38] *** praseodym has joined #chromium
[14:55:59] <jorlow> maruel: no...but as far as i know it was more of a prioritization thing...they decided the overhead of having more processes wasn't that bad compared to the overhead of allowing multiple v8 threads per process
[14:56:16] <jorlow> i.e. i don't know how tough the technical challenges were
[14:56:21] <maruel> ok
[14:56:44] <jorlow> i'm not sure everyone agreed with the v8 team's decision btw  :-)
[14:56:45] <maruel> in general, globals are bad but I guess they have more constrains that I know :(
[14:56:51] <maruel> ok
[14:57:00] * maruel recalls x64 implementation ... :)
[14:57:01] <jorlow> i think it becomes tougher when you're generating code too
[14:57:17] <maruel> bah, as long as they use different heaps, it's non issue
[14:57:20] <jorlow> but...i'm surprised some sort of tls based approach wouldn't be too easy
[14:57:21] <jorlow> yeah
[14:57:26] <maruel> but if you can't share context, it's not really useful after all
[14:57:41] <jorlow> yes and no....processes are expensive
[14:57:43] <jorlow> and there are limits
[14:57:54] <jorlow> that are more restrictive than thread limits
[14:58:09] <ejpbruel> ok
[14:58:09] <jorlow> anyway.....all i know is second and third hand....
[14:58:14] <ejpbruel> my boss just barged in
[14:58:22] <ejpbruel> he wants me to reimplement the sample for win32
[14:58:29] <ejpbruel> so that we can use the vs debugger
[14:58:33] <ejpbruel> i doubt its gonna help much tho
[14:58:34] <jorlow> what sample?
[14:58:40] <ejpbruel> oh i wrote a piece of sample code
[14:58:46] <ejpbruel> to test if v8 would work with makecontext/swapcontext
[14:59:00] <jorlow> ah
[14:59:02] <ejpbruel> actually the context swapping seems to work, v8 doesnt crash or anything
[14:59:04] <ejpbruel> the main problem is
[14:59:18] <ejpbruel> that if i do a call to a function object from any thread context but the one on which i initialized v8
[14:59:21] <ejpbruel> v8 seems to get confused
[14:59:44] <ejpbruel> im not really surprised because each fiber has its own stack
[14:59:57] <ejpbruel> im guessing v8 is trying to walk up back the stack but cannot find the information it expects to be there
[15:00:02] <ejpbruel> so it assumes i've run out of the stack
[15:00:21] <maruel> ejpbruel: I thought you were using linux
[15:00:23] <ejpbruel> hence the Uncaught RangeError: Maximum call stack size exceeded
[15:00:29] <ejpbruel> well, i *was*
[15:00:37] <ejpbruel> this project is eventually supposed to run on linux
[15:00:47] <maruel> ok
[15:00:51] <ejpbruel> the only reason my boss wants me to reimplement it for win32 is so that we can debug it easier
[15:00:57] <maruel> ahah
[15:00:59] <jorlow> what's this project for?
[15:01:10] <maruel> *the* question :)
[15:01:20] <ejpbruel> simply put, an alternative to nodejs
[15:01:28] <rsesek> maruel: what's the status of the win trybot?
[15:01:32] <ejpbruel> well thats a bit of an oversimplification
[15:01:43] <maruel> rsesek: sick
[15:01:48] <rsesek> :(
[15:02:04] <ejpbruel> @jorlow http://www.ajax.org/#o3 this is the project im working on (if youre interested)
[15:02:27] <jorlow> interesting  :-)
[15:02:27] <maruel> let me clobber them all
[15:02:35] <jorlow> yeah....seems like a good use case for multi-threaded v8
[15:02:54] <ejpbruel> jupp, now if only I could get it to work :)
[15:02:55] *** shenki has quit IRC
[15:03:33] <ejpbruel> i dont particularly *like* stack tracing v8 to figure out how it works
[15:04:01] <jorlow> pretty cool stuff tho....good luck!
[15:04:08] *** shenki has joined #chromium
[15:04:10] <ejpbruel> @jorlow thx
[15:04:24] <ejpbruel> i'll figure out something :)
[15:04:45] <ejpbruel> thank your for the info
[15:04:48] <ejpbruel> @maruel you too
[15:05:18] <maruel> ejpbruel: good luck
[15:05:37] <maruel> I'm always surprised how ppl write stuff in JS, I still think it's an awful language
[15:06:19] <jorlow> maruel: it's a very different language....once you get used to its quirks, people seem to like it
[15:06:24] <phajdan-jr> maruel: maybe they compile some better language to JS ;-)
[15:06:32] <jorlow> even more so, i can't understand why people like PHP
[15:06:38] <maruel> eh
[15:06:40] <rsesek> jorlow: PHP is faaaast to develop with
[15:06:46] <jorlow> any language where half is case sensitive and half isn't.......
[15:07:14] *** Sarten-X has quit IRC
[15:07:58] <rsesek> but I agree about JS. because I don't specify |var|, a variable turns into a global? that's fun
[15:12:56] <ejpbruel> one more question guys, do you know if its possible to share the global object between different v8 contexts?
[15:15:37] <maruel> try server reopened
[15:19:32] *** RT|Chatzilla has quit IRC
[15:20:34] <jorlow> ejpbruel:  can you think of a case where it'd be done today in chrome?
[15:20:45] <jorlow> if not, then at best it's probably not a very well tested code path
[15:20:53] <jorlow> i have no idea though
[15:29:01] *** magn3ts has joined #chromium
[15:31:14] *** phajdan-jr is now known as phajdan-jr|afk
[15:34:56] *** Arc__ has joined #chromium
[15:36:22] <Arc__> are there any docs on the v8 architecture? i'm trying to figure out what globals that thing keeps
[15:36:45] <jorlow> Arc__ are you in anyway connected to ejpbruel ?
[15:36:48] <Arc__> i dont want the thing to be multithread safe, just allow multiple callstacks
[15:36:50] <Arc__> jep
[15:36:56] <Arc__> trying to solve the same problem
[15:37:07] <jorlow> k...talk to him  :-)    he just asked a bunch of the same questions
[15:37:15] <Arc__> we know the same :)
[15:37:38] <ejpbruel> hey Arc_
[15:37:42] <Arc__> sup eddy
[15:39:50] *** Sarten-X has joined #chromium
[15:39:55] *** RT|Chatzilla has joined #chromium
[15:44:03] *** phajdan-jr|afk has quit IRC
[15:44:39] *** zerwas has quit IRC
[15:45:26] *** cbentzel has quit IRC
[15:50:36] *** dmaclach has joined #chromium
[16:06:47] *** jrmuizel has joined #chromium
[16:09:34] * maruel smells the refreshing odour of greeness of the try server
[16:10:08] <rsesek> yay refreshing odors!
[16:12:04] *** dmaclach has quit IRC
[16:13:34] *** dglazkov has joined #chromium
[16:13:35] *** ChanServ sets mode: +v dglazkov
[16:17:35] <maruel> "cl : Command line error D8027 : cannot execute 'c:\Program Files\Microsoft Visual Studio 8\VC\bin\c2.dll'"
[16:17:39] <maruel> love that
[16:20:00] *** trungl has quit IRC
[16:22:54] *** tittiatcoke has quit IRC
[16:27:08] *** Singularity has joined #chromium
[16:27:16] *** Zucca has joined #chromium
[16:32:12] *** trungl_mbp has joined #chromium
[16:32:46] *** skerner_ has joined #chromium
[16:32:47] *** trungl_mbp is now known as trungl
[16:32:54] *** ChanServ sets mode: +v trungl
[16:33:14] *** skerner_ has quit IRC
[16:34:38] *** stuartmorgan has joined #chromium
[16:34:38] *** ChanServ sets mode: +v stuartmorgan
[16:40:00] *** Singularity has quit IRC
[16:42:25] *** monreal has joined #chromium
[16:49:50] *** skerner has quit IRC
[16:49:59] *** dglazkov has quit IRC
[16:51:37] *** tedoc2000 has joined #chromium
[16:52:58] *** dmaclach has joined #chromium
[16:56:28] *** stuartmorgan_ has joined #chromium
[16:56:29] *** ChanServ sets mode: +v stuartmorgan_
[16:57:37] *** stuartmorgan_ has quit IRC
[17:06:10] *** dmaclach has quit IRC
[17:09:59] *** dmaclach has joined #chromium
[17:10:26] *** RT|Chatzilla has quit IRC
[17:13:47] *** rohitrao has joined #chromium
[17:13:47] *** ChanServ sets mode: +v rohitrao
[17:14:20] *** mrossetti has joined #chromium
[17:14:31] *** mrossetti_ has joined #chromium
[17:14:47] *** lilmatt has joined #chromium
[17:19:04] *** mrossetti has quit IRC
[17:19:04] *** mrossetti_ is now known as mrossetti
[17:25:11] *** Venom_X has joined #chromium
[17:26:35] <motownavi> mirandac: ping
[17:26:43] <mirandac> motownavi: pong
[17:26:52] <motownavi> are you actively working on 21672?
[17:27:05] <motownavi> it's themes, and if you're not working on it then I'm in themes mood
[17:27:22] <mirandac> oh, no, I am not -- please feel free to jump on it
[17:27:29] <motownavi> cool
[17:27:46] <mirandac> yay!
[17:27:47] * motownavi is theme happy and gets to learn how popup windows now work
[17:28:24] <mirandac> motownavi: are you going to do the win side as well, or just the mac side?
[17:28:31] <motownavi> er
[17:28:32] <motownavi> mac
[17:28:35] <motownavi> that's the bug
[17:28:43] <motownavi> waaaiiit
[17:28:50] <motownavi> no, it's an os-all :(
[17:28:52] <mirandac> motownavi: I think it's all OSes
[17:28:55] <mirandac> yeah
[17:29:03] <motownavi> I have some ideas about os-mac
[17:29:07] *** taf2 has quit IRC
[17:29:14] <mirandac> but you should do the os-mac side, still
[17:29:19] <motownavi> but i'd like to split the bug
[17:29:23] <mirandac> I think the solution will be quite different on the win side
[17:29:26] <mirandac> yes, that's a good idea
[17:29:32] <motownavi> very likely.
[17:29:53] <mirandac> leave me with the win side, then; I've done lots of theme stuff over there
[17:30:05] <motownavi> sounds like a plan
[17:30:41] *** dglazkov has joined #chromium
[17:30:42] *** ChanServ sets mode: +v dglazkov
[17:35:28] *** skerner has joined #chromium
[17:43:55] *** Twey has joined #chromium
[17:44:07] *** trungl has quit IRC
[17:44:19] *** jarsen has joined #chromium
[17:45:49] <motownavi> mirandac: popup windows are themed on the mac already...
[17:45:53] <motownavi> I'm going to drop the os-mac
[17:46:01] *** jarsen has quit IRC
[17:46:18] <mirandac> motownavi: all right.  somebody obviously pressed the wrong button.  thanks.
[17:46:40] <motownavi> np, fixing the bug
[17:47:48] *** markmentovai has joined #chromium
[17:47:48] *** ChanServ sets mode: +v markmentovai
[17:47:50] <pkaddi> motownavi: they are themed in ubuntu too. i jus tried
[17:48:04] <motownavi> pkaddi: really? cool. I'll detag that too.
[17:49:00] <motownavi> see mirandac? watch the bug get smaller and smaller :)
[17:49:15] <mirandac> motownavi: can you repeat that trick for all my other bugs?  :-D
[17:49:20] <motownavi> :P
[17:49:35] <mirandac> motownavi: you have the magic touch!  :-)
[17:51:40] *** GabydeWilde_ has quit IRC
[17:52:53] <rsesek> linking chrome and unit_tests in a linux vm is incredibly slow :(
[17:53:02] *** andybons has joined #chromium
[17:55:54] *** Hanumaan has joined #chromium
[17:55:57] *** dmaclach has quit IRC
[17:56:36] <pkaddi> mirandac: hey u need any help with those bugs. i hav jus started on chromium, will be gald to help
[17:57:52] *** dmaclach has joined #chromium
[17:59:15] <mirandac> pkaddi: thanks for the offer.  have you looked through the chromium bugs for "HelpWanted" tags?  that's a good place to start.  I may have a few of those I haven't started yet -- if you see one you'd like to try, go ahead.
[17:59:32] *** trungl_afk is now known as trungl
[18:01:58] *** ejpbruel has left #chromium
[18:02:35] *** kuchhal has joined #chromium
[18:02:35] *** ChanServ sets mode: +v kuchhal
[18:03:37] *** snej has joined #chromium
[18:09:36] *** Hanumaan has quit IRC
[18:09:40] *** Hanumaan has joined #chromium
[18:11:42] *** MikeSmithXX has quit IRC
[18:11:45] *** kuchhal has quit IRC
[18:12:07] *** kuchhal has joined #chromium
[18:12:08] *** ChanServ sets mode: +v kuchhal
[18:13:11] *** systemIX has joined #chromium
[18:14:49] *** wyck has joined #chromium
[18:16:50] *** MikeSmithXX has joined #chromium
[18:26:04] *** kib0 has joined #chromium
[18:26:16] <kib0> does chrome 5 supports web sockets?
[18:29:27] *** luke_ has quit IRC
[18:29:52] *** luke_ has joined #chromium
[18:32:46] *** DaveL2 has joined #chromium
[18:38:43] *** mmoss has joined #chromium
[18:38:47] *** btipling has quit IRC
[18:39:04] *** jlouie has joined #chromium
[18:39:56] *** spsneo has joined #chromium
[18:41:47] *** Hanumaan has quit IRC
[18:42:33] <spsneo> I am writing an extension for squirrel mail. which helps users to automatically login to their inbox. But when I submit the form using js in content script, it says wrong password. But when I set an alert before submitting the form, it works fine.
[18:42:37] <spsneo> can anybody help me?
[18:46:14] *** thakis has joined #chromium
[18:46:14] *** ChanServ sets mode: +v thakis
[18:50:33] *** lzheng has joined #chromium
[18:51:02] *** Arc__ has quit IRC
[18:51:49] *** wyck has quit IRC
[18:54:06] *** dmaclach has quit IRC
[18:56:42] *** bweinstein has joined #chromium
[18:57:30] *** asac has quit IRC
[18:57:46] *** dmaclach has joined #chromium
[18:58:52] *** asac has joined #chromium
[18:59:02] <rohitrao> stuartmorgan: flash fullscreen hides the dock completely (not autohide).  Do you have any idea how they do that?
[18:59:30] <stuartmorgan> rohitrao: I think it's just our fullscreen call
[19:00:06] <rsesek> snej: net_unittest failure
[19:00:18] *** bent-mozilla has joined #chromium
[19:00:21] <rohitrao> stuartmorgan: as far as I can tell, our fullscreen call autohides the dock.  Maybe they're setting up a tracking area and stealing mouseMoved events, or something
[19:00:38] <stuartmorgan> rohitrao: hm, not sure then
[19:00:44] <snej> rsesek: Thanks for the heads-up. I'm looking.
[19:01:14] *** tittiatcoke has joined #chromium
[19:02:55] <trungl> rohitrao: Isn't it one of the options in the fullscreen (SetUIMode or whatever it's called) call?
[19:03:05] <snej> Hm, it looks as though the keychain on the Mac test bot is locked. It's getting errSecAuthFailed trying to generate a key-pair.
[19:03:10] <snej> This didn't happen on the try bots :(
[19:03:16] <markmentovai> snej, which bot?
[19:03:23] <rohitrao> trungl: the call I'm making should be autohiding the dock, but when flash is fullscreen the dock is completely gone
[19:03:46] *** acon has joined #chromium
[19:03:53] <snej> markmentovai: "Modules Mac10.5" and "Modules Mac10.5 dbg"
[19:04:07] <trungl> rohitrao: oh, you're complaining about the dock being gone
[19:04:31] <trungl> (right?)
[19:04:35] <sbyer> rohitrao: flash is probably using the Quartz monitor full-screen API that's meant for games.
[19:04:35] *** mlevin` has joined #chromium
[19:04:48] <rohitrao> trungl: yeah, i miss my dock :)
[19:05:01] <markmentovai> snej: nope, login keychain is unlocked on each
[19:05:17] <markmentovai> keychain is empty in each case
[19:05:23] <rohitrao> sbyer: well, flash is in a different process, so I thought it couldn't make any of those calls
[19:05:39] <snej> markmentovai: Weird. Should I just disable that test to re-open the tree? (And if so, how do I do that?)
[19:05:57] <markmentovai> disable the test by renaming the test to include DISABLED_ in its name
[19:06:05] <markmentovai> for example, KeygenHandlerTest.DISABLED_SmokeTest
[19:06:16] <markmentovai> you can use preprocessor magic if it's a cross-platform test and you only want to disable it on the mac
[19:06:17] <trungl> rohitrao: I'm still unconvinced that we should have the Dock autohiding.
[19:06:25] <snej> markmentovai: Right in the _unittest.cc file? OK. Do I need a review for that or can I just check in immediately?
[19:06:33] <markmentovai> you can check it in immediately
[19:06:49] <sbyer> rohitrao: yeah, I still have to learn what APIs they have access to from that process.  There are a number of dock hiding tricks (undocumented window levels, etc).
[19:06:56] <snej> markmentovai: Or can I mark it as "flaky" so it still runs but doesn't block the testing?
[19:07:01] <trungl> rohitrao: a) It might get in the way of the bar if the dock is on the side.
[19:07:12] <rohitrao> trungl: it's going to end up being hidden completely.  Right now it's only autohidden when the overlay is down (completely gone otherwise), which is silly and weird
[19:07:14] <markmentovai> yeah, FLAKY_ instead of DISABLED_...
[19:07:17] <trungl> rohitrao: b) I don't think any other apps' fullscreen mode has the dock autohiding.
[19:07:22] <markmentovai> but long-term, i'm not sure about tests that modify the keychain
[19:07:28] *** erikkay has joined #chromium
[19:07:32] *** dave_levin has joined #chromium
[19:07:42] <markmentovai> (not really sure if that's what your test does here)
[19:07:51] <rohitrao> sbyer: ah, maybe that's it then.  their window is above the dock but below the menubar
[19:07:52] <trungl> rohitrao: so that would make it consistent with flash's fullscreen mode, no?
[19:08:10] *** mpcomplete has joined #chromium
[19:08:11] *** ChanServ sets mode: +v mpcomplete
[19:08:14] <rohitrao> trungl: yup, initially i thought flash showed the dock
[19:08:23] <rohitrao> which is why i was going for autohide
[19:08:29] <trungl> ah
[19:08:51] *** mpcomplete is now known as mpcomplete_wfh
[19:09:10] *** rafaelw has joined #chromium
[19:11:15] *** fishd has joined #chromium
[19:11:15] *** ChanServ sets mode: +v fishd
[19:12:57] *** dmaclach has quit IRC
[19:13:02] *** dmaclach has joined #chromium
[19:16:41] <snej> OK, I have marked the test as flaky. Will the tree reopen by itself or do I need to kick something?
[19:17:04] *** pkaddi has left #chromium
[19:17:10] <nsylvain> you need to reopen it manually
[19:17:20] <nsylvain> is the test really flaky though?
[19:17:29] <nsylvain> it seems like it has been failing consistantly
[19:17:30] *** scherkus has joined #chromium
[19:17:53] <nsylvain> if the test is not ready, i think you should revert the code instead
[19:17:55] <snej> It's failing on the test bot. But it works on the try bots. I want to figure out what's wrong with it.
[19:18:20] <snej> It has something to do with the state of the Keychain on the test machine ? it's not getting permission to generate a keypair.
[19:18:31] <nsylvain> ok
[19:18:39] *** rjkroege has joined #chromium
[19:19:22] *** rafaelw has left #chromium
[19:19:24] <nsylvain> it actually passes on 10.6
[19:19:26] <nsylvain> but not 10.5
[19:20:04] <snej> Tree is back open. We apologize for the inconvenience.
[19:20:10] <nsylvain> internet says "-25293 means you don't have authorization for that keychain. Simple answer is to start a fresh one!"
[19:20:39] <motownavi> pinkerton: crbug.com/37111 is you :(
[19:20:51] <lzheng> snej, nsylvain, thanks for reopening the tree.
[19:20:57] <snej> nsylvain: It also happens if the keychain is locked and the task is running non-interactively, which is my guess.
[19:21:13] <nsylvain> lzheng: looks like it's going to need a clobber
[19:21:22] <nsylvain> XP tests failure looks like a grd problem
[19:21:26] <nsylvain> i'll clobber
[19:21:45] <pinkerton> motownavi: is that the performSelectorOnMainThread thing?
[19:21:49] <motownavi> yes
[19:21:52] <pinkerton> gah
[19:22:00] <pinkerton> rohit found another issue with that as well yesterday
[19:22:05] <pinkerton> i wonder why it's so lame
[19:22:07] <motownavi> really?
[19:22:08] <motownavi> huh
[19:22:12] <pinkerton> yeah, it' s weird
[19:22:14] <motownavi> you see the stuttering?
[19:22:26] <pinkerton> i haven't tried, heads down on plugins
[19:22:51] <motownavi> oh. rohitrao? what did you find about r36755?
[19:24:12] <jam2> hey guys, just reading the history for the build failures, thanks for being on top of things.  still on shuttle and have hiring committee now, but will be on after
[19:25:04] <rohitrao> motownavi: set some breakpoints, but didn't get very far.  For some reason we think the tab strip is empty, so we close the window.
[19:25:23] <motownavi> what's the issue when that happens?
[19:26:20] *** rafaelw has joined #chromium
[19:26:22] <rohitrao> motownavi: http://code.google.com/p/chromium/issues/detail?id=37091
[19:26:53] <rohitrao> motownavi: the extra bad flicker was also from that same cl, although there was always a slight flicker
[19:27:35] <nsylvain> hclam: ping
[19:27:51] <snej> markmentovai: Is there a way I can remote-desktop into the test Mac to look at its keychain?
[19:27:53] <motownavi> I never saw the "slight" flicker from before
[19:28:04] <motownavi> but yeah, 36755 makes it pretty nasty
[19:28:12] *** scherkus_ has joined #chromium
[19:28:17] *** rjkroege has quit IRC
[19:28:52] <rohitrao> i forget what it was, can't find the bug now.  When you started the drag, the window would flicker transparent and then back to solid
[19:29:23] <motownavi> well, let's fix this one now and see...
[19:30:19] <motownavi> 36755 fixed a cmd-w killing window rather than tab? I'm a bit unclear about what happens there. looking... :(
[19:31:40] *** scherkus has quit IRC
[19:32:33] <pinkerton> motownavi: it worked around the fact that we were getting a notification on a thread w/out a runloop, so the timer we kicked off to fix the cmd-w/cmd-shift-w menu items would never fire
[19:32:38] <pinkerton> and would get stuck in that state forever
[19:32:38] *** rvargas has quit IRC
[19:33:53] *** BALAMUT has joined #chromium
[19:34:08] <motownavi> how did the nswindow notifications ever come off the main thread?
[19:34:53] *** roc has quit IRC
[19:35:00] <BALAMUT> Hi to all. I have a problem with build chromium on linux. I can't compile static build. Anybody help me?
[19:35:32] <pinkerton> motownavi: someone was (incorrectly) calling cocoa things on the non-main thread
[19:35:50] <pinkerton> motownavi: we first had this issue with the d/l strip, but another appears to have crept in
[19:36:06] <motownavi> wouldn't the dcheck catch that?
[19:36:07] <pinkerton> motownavi: where from? who knows. we need to put some CHECKs in to catch the stacks, but that requires some coordination with release
[19:36:24] <pinkerton> sure, but that only captures if anyone surfs long enough in debug, and it doesn't get reported
[19:37:41] *** roc has joined #chromium
[19:38:30] <motownavi> Doesn't everyone use ToT in debug enough to catch things? 36755 feels like it creates more problems than it solves
[19:38:40] <motownavi> (the onMainThread part, not the DCHECK)
[19:38:50] <pinkerton> it seemed to have fixed people bitching that cmd-w closed the window
[19:38:50] <jam2> nsylvain: loks like Vista Tests (dbg) needs to be cloberred as well
[19:38:56] <jam2> nsylvain: i'll take care of it
[19:39:07] <nsylvain> right
[19:39:08] <pinkerton> and no, i doubt people run ToT in debug much at all
[19:39:09] <rsesek>  set down traps
[19:39:18] <pinkerton> in fact, i almost never surf in debug
[19:39:51] <rsesek> woops wrong window. stupid janky computer
[19:40:36] <jam2> nsylvain: hmm, did something change?  I dont see the clobber link when i click on a slave?
[19:40:40] *** BALAMUT has left #chromium
[19:40:49] <jam2> i.e. here http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests%20(dbg)(1)
[19:40:51] <nsylvain> jam2: you must be looking at the external view of the waterfall
[19:40:53] <nsylvain> yup
[19:41:09] <jam2> ahh, ok, will change, thanks
[19:41:14] <jam2> what'sthe url?
[19:42:07] *** tbassetto has quit IRC
[19:42:40] <nsylvain> it was in your chat window before you asked; )
[19:43:22] <nsylvain> anyone knows where fbarchard or hclam are?
[19:43:53] *** skrul_ has quit IRC
[19:44:46] *** rjkroege has joined #chromium
[19:45:09] <awong> nsylvain: fbarchard's around
[19:45:11] <awong> but what do you need?
[19:45:39] <nsylvain> one of them broke chromeos yesterday afternoon with a ffmpeg change, and i was going to revert both of them if they dont come online soon
[19:46:10] <awong> let me try to grab fbarchard.
[19:46:14] <nsylvain> thanks
[19:46:33] *** rvargas has joined #chromium
[19:46:41] <nsylvain> awong: chromeos, valgrind mode :
[19:46:50] <nsylvain> ./b/slave/chromium-rel-chromeos-valgrind-tests-1/build/src/third_party/ffmpeg/source/patched-ffmpeg-mt/libavcodec/x86/dsputil_mmx.c: In function 'add_hfyu_median_prediction_cmov':
[19:46:50] <nsylvain> ./b/slave/chromium-rel-chromeos-valgrind-tests-1/build/src/third_party/ffmpeg/source/patched-ffmpeg-mt/libavcodec/x86/dsputil_mmx.c:605: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
[19:46:50] <nsylvain> ./b/slave/chromium-rel-chromeos-valgrind-tests-1/build/src/third_party/ffmpeg/source/patched-ffmpeg-mt/libavcodec/x86/dsputil_mmx.c:605: error: 'asm' operand has impossible constraints
[19:47:06] <awong> ah frig.
[19:47:17] <awong> I hate that error.
[19:47:56] <awong> I'm having a problem finding the bot + CL, do you have the bot link handy?
[19:48:05] *** jamesr has joined #chromium
[19:48:15] <nsylvain> memory waterfall, the last red squares on the forth row
[19:48:20] <nsylvain> http://build.chromium.org/buildbot/memory/waterfall?builder=Chromium%20OS%20UI%20(valgrind)(1)
[19:48:35] <awong> got it. thanks
[19:49:52] <lzheng> nsylvain: were you able to clobber the build?
[19:50:14] *** fbarchard has joined #chromium
[19:50:23] <nsylvain> lzheng: chromeos? or the other xp-tests, etc failures?
[19:50:26] <nsylvain> i clobbered both
[19:50:34] <nsylvain> pretty sure it will work for xp tests, but not for chromeos
[19:51:06] <fbarchard> nsylvain: did the internal deps roll break something?
[19:51:33] <lzheng> The tree still claim it is closed. It is claim vista tests this time.
[19:52:20] <nsylvain> fbarchard: I guess so.
[19:52:20] <nsylvain> [10:49] <nsylvain> awong: chromeos, valgrind mode :
[19:52:20] <nsylvain> [10:49] <nsylvain> ./b/slave/chromium-rel-chromeos-valgrind-tests-1/build/src/third_party/ffmpeg/source/patched-ffmpeg-mt/libavcodec/x86/dsputil_mmx.c: In function 'add_hfyu_median_prediction_cmov':
[19:52:21] <nsylvain> [10:49] <nsylvain> ./b/slave/chromium-rel-chromeos-valgrind-tests-1/build/src/third_party/ffmpeg/source/patched-ffmpeg-mt/libavcodec/x86/dsputil_mmx.c:605: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
[19:52:21] <nsylvain> [10:49] <nsylvain> ./b/slave/chromium-rel-chromeos-valgrind-tests-1/build/src/third_party/ffmpeg/source/patched-ffmpeg-mt/libavcodec/x86/dsputil_mmx.c:605: error: 'asm' operand has impossible constraints
[19:52:26] <nsylvain> lzheng: reopen it
[19:52:36] <lzheng> k
[19:53:43] <awong> fbarchard: must be.  The change that it started failing on was alpha's disable of a unittest.  That couldn't have caused htis since the error is pretty clearly the -fPIC or -O0 issue.
[19:53:45] <fbarchard> I see compile error dsputil_mmx.c:605: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
[19:53:51] <lzheng> nsylvain: what about the failures?
[19:54:27] *** rjkroege has quit IRC
[19:55:04] <nsylvain> lzheng: you sound investifate the browser_Tests (mac, linux).  The windows should cycle green
[19:55:34] *** urbanape has quit IRC
[19:56:20] *** jrmuizel has quit IRC
[19:56:27] *** asac has quit IRC
[19:57:25] *** jrmuizel has joined #chromium
[19:58:01] *** rjkroege has joined #chromium
[19:58:15] <fbarchard> i think i know what it is.  I didn't think we used valgrind on chromium.  theres a hack i need to do to cripple ebp/ebx
[19:59:22] <fbarchard> should take 5 minutes to fix...
[19:59:32] *** urbanape has joined #chromium
[20:01:20] <andybons> finnur: ping
[20:01:24] *** pfeldman has quit IRC
[20:01:50] <finnur> andybons: pong
[20:01:59] *** fqian_ has joined #chromium
[20:03:16] *** urbanape has quit IRC
[20:04:14] <rohitrao> trungl: holy crap, this might actually work
[20:04:37] <fbarchard> CL40398 should fix valgrind on chromiumos
[20:05:18] <trungl> rohitrao: :)
[20:05:41] *** luke_ has quit IRC
[20:05:55] *** asac has joined #chromium
[20:05:58] *** asac has quit IRC
[20:05:58] *** asac has joined #chromium
[20:06:13] <motownavi> rohitrao: what?
[20:07:32] *** andrix1 has quit IRC
[20:08:21] <rohitrao> trungl: http://codereview.chromium.org/661380/show
[20:08:32] <zer0her0> just saw the new DL badge in chromium for OS X, that's sexi
[20:08:44] <rohitrao> motownavi: we're tying the menubar to the fullscreen overlay, so the menubar only shows up when the overlay is down
[20:08:49] *** cst has joined #chromium
[20:08:50] <motownavi> ah
[20:08:55] <motownavi> not the dragging issue
[20:09:27] *** urbanape has joined #chromium
[20:09:34] <rohitrao> no, nothing quite so exciting :)
[20:13:08] <snej> How can I get GUI access to the "Modules Mac10.5" test bot?
[20:13:20] <snej> I need to track down this keychain issue that broke my test.
[20:13:34] *** franksalim has joined #chromium
[20:14:00] <rohitrao> snej: markmentovai might be able to help you?
[20:14:11] <rohitrao> just make sure the mouse pointer is completely offscreen before you log out ;)
[20:14:19] <markmentovai> snej, its keychain is completely empty
[20:14:40] <snej> markmentovai: I want to run first aid on it to see if it's corrupt.
[20:17:04] <markmentovai> snej: "No problems found"
[20:17:40] <snej> markmentovai: Thanks. And it's unlocked?
[20:17:45] <markmentovai> very much so
[20:19:16] <markmentovai> snej: and "security dump-keychain ~/Library/Keychains/login.keychain" prints nothing and exits 0.  perfectly empty.
[20:19:58] *** pamg has joined #chromium
[20:19:59] *** ChanServ sets mode: +v pamg
[20:20:40] *** skerner has quit IRC
[20:20:40] <snej> markmentovai: Hm, I'm kind of stumped. Is there a way I can make changes to my test code and run it there, without having to actually check stuff in?
[20:21:53] <dumi> has anybody changed anything in test_shell in the last couple of days? it looks like the code does not bind a LayoutTestController instance to window.layouTestController, so all layout tests fail
[20:22:12] <markmentovai> snej: not really...
[20:22:27] <markmentovai> trybots, but you said this didn't happen on the trybots?
[20:22:39] <snej> markmentovai: Yeah, it passed fine on the try bots.
[20:23:15] <markmentovai> let's check the trybot that handled this patch
[20:23:17] *** agl has joined #chromium
[20:23:17] *** ChanServ sets mode: +v agl
[20:23:43] <nsylvain> markmentovai: do we have try bots on 10.6 now?
[20:23:48] <markmentovai> not yet
[20:23:53] <nsylvain> hm ok
[20:23:55] <markmentovai> we only have the bots with 10.6 in their names on 10.6
[20:24:15] <snej> markmentovai: I just did a "git try", no parameters, so it's whatever the default Mac try bot is.
[20:24:37] <markmentovai> snej: yeah, if you look at a page like http://build.chromium.org/buildbot/try-server/builders/mac/builds/19937, you can see which slave actually handled the request
[20:24:40] <markmentovai> in this case, jega61
[20:25:09] <markmentovai> which also has an empty login.keychain
[20:26:34] *** mfinkle has joined #chromium
[20:27:24] <markmentovai> snej: the 10.6 modules bots liked the change though, right?
[20:27:28] *** luke_ has joined #chromium
[20:27:58] <snej> markmentovai: The failures came from Modules Mac10.5
[20:28:08] *** mun has joined #chromium
[20:28:19] <markmentovai> we have modules 10.6 bots too
[20:29:09] <snej> markmentovai: I added a bit of error logging and sent it to the mac try server.
[20:29:43] <markmentovai> errSecAuthFailed (-25293) is what we saw on the waterfall, right?
[20:30:03] <snej> markmentovai: Yes.
[20:30:04] *** rjkroege has quit IRC
[20:30:49] <markmentovai> i could reboot those two bots
[20:31:20] <snej> markmentovai: Might be worth a try. I saw a few posts where people had flaky problems with keychain access and that error code, usually resolved by relaunching or rebooting.
[20:31:24] <rohitrao> trungl: you were supposed to patch it in and play, not review ;)
[20:32:06] *** erikkay has quit IRC
[20:32:41] <markmentovai> ah, one problem here is that it's just "goto failure" so we don't know specifically which thing is failing
[20:33:43] <markmentovai> snej: as written, does this leak items in the keychain during unit testing, if a crash or other sort of interruption (tripped over the plug!) happens at the "right" time?
[20:35:07] *** skerner has joined #chromium
[20:36:20] <jam2> willchan: yt?
[20:36:59] *** spsneo has quit IRC
[20:42:35] <markmentovai> snej: reboot seems to have taken care of it, but please see my question above when you get back.  additionally, the right approach here may be to let the code work on a temporary throwaway keychain that the unit test itself controls - that way we can be assured of state in terms of cleanliness and unlockedness.
[20:47:23] *** dpranke has joined #chromium
[20:47:23] *** ChanServ sets mode: +v dpranke
[20:47:52] <pinkerton> motownavi: hrm, someone just followed up that cmd-w closes the window for them in 307, so maybe this patch is bad on every level
[20:48:09] <pinkerton> motownavi: but i can't explain how it can happen
[20:50:07] *** dknight has joined #chromium
[20:50:25] *** franksalim has quit IRC
[20:50:54] *** luke_ has quit IRC
[20:50:56] *** Venom_X is now known as Venom_lnch
[20:50:56] *** fbarchard has left #chromium
[20:50:59] *** luke_ has joined #chromium
[20:55:34] <rohitrao> pinkerton: this sounds like a totally different bug...?
[20:57:37] *** magn3ts has quit IRC
[20:58:26] <trungl> rohitrao: oh
[20:58:51] <trungl> rohitrao: I'm trying to figure out this annoying bar-getting-stuck bug
[20:59:11] <rohitrao> trungl: which bug is that?
[20:59:38] <trungl> rohitrao: the one which has been mentioned, but no bug filed
[21:00:00] <rohitrao> is this when the tracking area breaks and we can't get the overlay to come down again?
[21:00:08] <trungl> rohitrao: yes
[21:00:21] <rohitrao> trungl: i'm hoping my CL with make that go away :)
[21:00:25] <trungl> rohitrao: actually, if you switch windows (or something), you can get it to be stuck in the "open" position
[21:00:32] <trungl> rohitrao: maybe, though I'm sceptical
[21:00:45] *** stoyan has joined #chromium
[21:01:27] <pinkerton> rohitrao: how?
[21:02:06] <rohitrao> pinkerton: just guessing, but his brokenness goes much deeper than anything we've seen before, especially if simply quitting doesn't help
[21:02:15] <pinkerton> i think he's just on crack
[21:02:22] <rohitrao> or if the menu item is moving in the menu
[21:02:36] *** ananta has joined #chromium
[21:02:40] *** luke__ has joined #chromium
[21:02:46] <trungl> who's on crack?
[21:02:49] <jam2> ananta: yt?
[21:02:58] <trungl> which brokenness?
[21:04:24] *** pfeldman has joined #chromium
[21:04:54] <pinkerton> trungl: http://code.google.com/p/chromium/issues/detail?id=32786
[21:05:15] *** luke_ has quit IRC
[21:05:27] *** rubenbb has quit IRC
[21:05:40] <trungl> ah
[21:05:49] <trungl> the re-install thing does seem rather bogus
[21:06:02] * trungl wonders if the re-install involves a new keyboard.
[21:06:10] <markmentovai> yeah, that's crazy
[21:06:14] *** cbentzel has joined #chromium
[21:07:06] <trungl> we should ship a new keyboard with each update
[21:07:40] *** luke__ has quit IRC
[21:07:42] *** luke_ has joined #chromium
[21:08:45] *** Sennen has joined #chromium
[21:15:45] <nsylvain> jam2, lzheng: looks like there was another grd change that came in a broke the tests. clobbering again now
[21:16:02] <trungl> we should have sound themes
[21:16:47] *** magn3ts has joined #chromium
[21:16:56] *** dmaclach has quit IRC
[21:17:03] *** dmaclach has joined #chromium
[21:17:36] <jam2> nsylvain: do you think it's responsible for the bookmark test failures
[21:17:36] <jam2> ?
[21:17:43] <nsylvain> yes
[21:17:49] <jam2> ahhhhh, ok, thanks
[21:17:56] <jam2> so, how come it only started fialing with ananta's change? http://chrome-buildbot:8010/builders/Vista%20Tests%20(dbg)(1)
[21:17:57] *** dmaclach has quit IRC
[21:18:29] *** dmaclach has joined #chromium
[21:18:30] *** Venom_lnch has quit IRC
[21:18:47] *** dmaclach has quit IRC
[21:18:50] <nsylvain> jam2: because the console is wrong.
[21:19:05] <jam2> nsylvain: really?
[21:19:09] <nsylvain> yeah
[21:19:15] <jam2> why is that?
[21:19:19] *** dmaclach has joined #chromium
[21:19:25] <nsylvain> let me double check so I don't lie
[21:19:31] *** Venom_X has joined #chromium
[21:19:36] *** mun has left #chromium
[21:20:10] <jam2> and also, which other grd change do you mean?  i don't see any after snej's, and i thought we cloberred after that already?
[21:20:37] <nsylvain> mpcomplete
[21:20:40] <nsylvain> http://build.chromium.org/buildbot/waterfall/waterfall?branch=&builder=Chromium+Builder+(dbg)&builder=Vista+Tests+(dbg)(1)&committer=&reload=none
[21:20:40] *** dmaclach has quit IRC
[21:20:48] *** krisr_mbp has joined #chromium
[21:21:01] <nsylvain> Ok, so in the builder column, build 17248
[21:21:10] <nsylvain> there was ananta, mpcomplete and a few others
[21:21:12] *** dmaclach has joined #chromium
[21:21:30] <nsylvain> when it was done building, we triggered the vista testers
[21:22:07] <nsylvain> we tell building to give the builder the same changeset (list of changes in teh build), but one in a while, it truncates it (we never found why. This is in buildbot's code, not ours)
[21:22:20] <nsylvain> so build 20070 has the wrong changeset (it just knows about ananta)
[21:22:21] <jam2> ohhhhhhhhhh
[21:22:22] <jam2> wow
[21:22:26] <jam2> ok that's really confusing
[21:22:33] <nsylvain> during the extract build we did notice something was wrong
[21:22:33] <jam2> thanks for the explanation
[21:22:40] <nsylvain> so we turn it orange to show it
[21:22:58] *** krisr_mbp has quit IRC
[21:23:13] <nsylvain> but since we felt we had the right build and were testing the right thing, we did not turn the step red, even though the attribution for this build might be slightly wrong
[21:23:17] *** krisr_mbp has joined #chromium
[21:23:35] <nsylvain> so, if you see orange extract build, you can doubt what buildbot tells you
[21:23:45] *** Sennen has quit IRC
[21:23:55] <kib0> does chrome 5 supports web sockets?
[21:24:20] <jam2> nsylvain: ok, will wait for clobber
[21:25:30] <jamesr> kib0: yes. http://dev.chromium.org/developers/web-platform-status#TOC-Web-Sockets-in-Dev-
[21:27:15] <jam2> nsylvain: looks like the failing tests started passing after clobber, so i opened the tree
[21:27:20] <jam2> ananta: sorry we blamed you!
[21:27:28] <nsylvain> cool
[21:27:35] <rsesek> why do try jobs fail to attach to Rietveld issues sometimes?
[21:28:29] <jam2> actually, maybe i'll just wait for one green cycle
[21:28:40] <jam2> resek: probably because rietveld sometimes times out
[21:28:50] <jam2> because of slow datastore access in app engine
[21:28:59] <rsesek> ah
[21:29:29] *** cbentzel has quit IRC
[21:29:43] <kib0> jamesr, thanks :)
[21:31:56] *** urbanape has quit IRC
[21:33:45] *** urbanape has joined #chromium
[21:35:58] *** rjkroege has joined #chromium
[21:41:00] *** colp has joined #chromium
[21:42:17] *** Octoroks has joined #chromium
[21:42:41] <colp> Heyo. I cannot seem to find a plugin that would be able to pop up some information about an image, its URL would be enough for me. Any tips?
[21:42:52] <jam2> tree is open, have fun
[21:42:58] <colp> (Opening in a new tab is just too damn slow solution.)
[21:42:58] <jamesr> muahahahahaha
[21:43:12] <trungl> rohitrao: so can you repro the stuck-bar bug? does your new CL make it go away?
[21:43:34] *** tbassetto has joined #chromium
[21:43:43] <pinkerton> stuartmorgan: take a quick look at http://codereview.chromium.org/661391/diff/1/3?column_width=80
[21:43:49] <pinkerton> stuartmorgan: didn't you just write that?
[21:43:57] *** tbassetto has quit IRC
[21:44:10] <stuartmorgan> pinkerton: yes, I saw that go by
[21:44:23] <pinkerton> i guess the gpu plugin doesn't have a plugin member?
[21:44:29] <stuartmorgan> Apparently not
[21:44:44] <stuartmorgan> And I missed the check above when I added that code
[21:45:44] <pinkerton> k just wanted to make sure it was kosher
[21:46:21] <stuartmorgan> Well, the alternative would be crashing, so that seems like a good option ;0
[21:46:27] *** colp has left #chromium
[21:46:29] *** roc has quit IRC
[21:46:34] <pinkerton> yeah, it was crashing before
[21:46:53] <stuartmorgan> We'll probably want to name the GPU process eventually, but that can be done later
[21:46:55] *** acon has quit IRC
[21:46:59] <stuartmorgan> Once things settle a bit
[21:47:10] <pinkerton> of course, that means that with that fix, the gpu drawing should work, which means my not-working drawing code is a total mess :)
[21:49:51] *** erikkay has joined #chromium
[21:51:20] *** lilmatt has quit IRC
[21:52:36] <jam2> linux folks: any idea what "dromaeo_test" failures are? http://chrome-buildbot:8010/builders/Linux%20Perf%20(2)/builds/1465/steps/dromaeo_test/logs/stdio
[21:52:46] <jam2> [----------] 1 test from DromaeoTest
[21:52:46] <jam2> [ RUN      ] DromaeoTest.Perf
[21:52:46] <jam2> Xlib:  extension "RANDR" missing on display ":9.0".
[21:53:37] *** dknight has left #chromium
[21:53:55] <rohitrao> trungl: I have no real repro, just eventually it'll break
[21:54:01] <jam2> nsylvain: any idea about above?
[21:54:06] <trungl> rohitrao: right
[21:54:09] <trungl> rohitrao: me too
[21:54:22] <trungl> rohitrao: I was mostly asking whether you were able to reproduce it
[21:54:24] <nsylvain> the Xlib is not the error, since it does that even when it passes
[21:54:28] <trungl> (which you apparently can)
[21:54:39] <jamesr> timeout
[21:54:51] <nsylvain> as for the hang itself, no idea.  Maybe chase knows? I know he was investigating a similar error for moz http (which has been disabled), i wonder if it's the same problem.
[21:55:00] <nsylvain> Otherwise someone would have to debug it
[21:56:33] *** luke_ has quit IRC
[21:56:39] *** sbyer is now known as sbyer_afk
[21:56:43] *** monreal has quit IRC
[21:56:44] <jam2> nsylvain: thanks
[21:56:50] <jam2> chase: yt?
[21:57:09] <chase> looking
[21:57:12] <jam2> chase: any idea about the dromaeotest failure above?
[21:57:13] <jam2> thanks
[21:57:58] <chase> the moz-http hang i found was due to an infinite loop we could enter in the network stack
[21:58:13] <chase> i don't believe the dromaeo test uses the network stack
[21:58:20] <chase> (based on the runtest args)
[21:58:27] <jam2> what is the dromaeo test?
[21:58:34] <jamesr> dromaeo is a javascript benchmark suite
[21:58:39] <jamesr> does DOM manipulations, querySelector(), etc
[21:58:48] <jamesr> it's http://dromaeo.com/
[21:59:03] <jam2> ah, that, i see
[21:59:05] <jam2> thanks
[21:59:18] <chase> it's a flaky error, too
[21:59:41] <jam2> is it?  it's been red for 4 builds
[21:59:50] <jam2> "Xlib:  extension "RANDR" missing on display ":9.0"." doesn't mean anything to me
[21:59:57] <nsylvain> it's not an error
[22:00:05] <chase> before that it was green for 2 builds, and red again for 5+ builds before that
[22:00:16] <nsylvain> it's been like that for a few days i think
[22:00:24] <jam2> ah i didnt know that, thanks fo rletting me konw
[22:00:27] <chase> close enough to track it
[22:00:52] *** quaelin has joined #chromium
[22:02:12] *** roc has joined #chromium
[22:02:53] <trungl> rohitrao: it may well be a cocoa bug
[22:03:55] <trungl> rohitrao: I suspect that it ends up sitting in a "pending installed" state
[22:04:03] <trungl> rohitrao: it = the tracking area
[22:04:18] <rohitrao> what does pending installed mean?
[22:06:53] <trungl> rohitrao: it means that when I NSLog it, it shows a "pendingInstalled" flag set, I think
[22:07:02] <chase> jam2: looks like it started failing around r40161.  maybe caused anywhere from that to r40150, depending on how flaky it is?
[22:07:02] *** ChanServ sets mode: +v willchan_
[22:07:05] <chase> jam2: http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Perf%20(2)&force=1&last_time=1267221925
[22:07:16] <trungl> rohitrao: it also means that searching for it reveals people asking about tracking areas being stuck
[22:07:26] <rohitrao> trungl: hooray :)
[22:07:37] <trungl> rohitrao: I haven't actually found a concrete solution to it!
[22:07:43] <rohitrao> i remember thinking it might be related to all of the animation
[22:07:49] <trungl> rohitrao: but perhaps if I call the view's -updateTrackingAreas ...
[22:08:09] <rohitrao> although that doesn't make sense, since we don't actually set any tracking areas until the animation is done
[22:09:50] <trungl> rohitrao: nothing about this makes sense to me
[22:10:44] <jam2> chase: thanks
[22:11:28] *** HighBit has quit IRC
[22:11:54] <jam2> chase: perhaps 40158
[22:11:57] <trungl> rohitrao: argh, it didn't fix it
[22:12:13] <jam2> is thestig here?
[22:12:13] <rohitrao> trungl: "it" == updateTrackingAreas? or my CL?
[22:12:14] *** brettw has quit IRC
[22:12:30] <trungl> rohitrao: it == -updateTrackingAreas
[22:12:35] <rohitrao> ok
[22:12:42] *** jlouie has quit IRC
[22:13:09] <chase> jam2: my guess, too.  it had a big effect on the dhtml page cycler results on linux perf, so it's at least not an insubstantial change.
[22:13:32] <jam2> chase: maybe we should revert it and check
[22:13:33] *** ROBOd has quit IRC
[22:13:35] <jam2> i'm pinging thestig
[22:15:39] <rsesek> pinkerton: ForMerge things go to 307?
[22:15:46] *** jrmuizel has quit IRC
[22:15:56] <pinkerton> no, we should have a new branch soon, but not sure when
[22:16:00] <rsesek> ok
[22:16:04] *** jrmuizel has joined #chromium
[22:16:04] <rsesek> then hopefully I can land before it's cut
[22:16:45] <jam2> chase: btw, when you say big effect, big as in positive or negative?
[22:16:54] <chase> positive, dhtml got ~60-70ms faster
[22:17:12] <jam2> chase: i see.  well i'm going to try reverting it
[22:18:51] <chase> jam2: okay.  when you do, linux perf dhtml will go red.  that's safe to ignore.
[22:18:59] <jam2> ok
[22:19:27] *** brettw has joined #chromium
[22:19:27] *** ChanServ sets mode: +v brettw
[22:20:11] *** mlevin` has quit IRC
[22:21:23] <thakis> i doubt thestig's patch is to blame for DISPLAY errors
[22:22:43] <chase> thakis: the display error is present when the test passes, too (not unique to the hanging case)
[22:25:03] *** markmentovai_ has joined #chromium
[22:25:03] *** ChanServ sets mode: +v markmentovai_
[22:26:27] *** fishd_ has joined #chromium
[22:26:27] *** ChanServ sets mode: +v fishd_
[22:27:47] <rohitrao> trungl: i think it's harder to trigger with my cl? maybe?
[22:27:53] *** magn3ts has quit IRC
[22:28:05] *** kemp has joined #chromium
[22:28:14] *** markmentovai has quit IRC
[22:28:14] *** markmentovai_ is now known as markmentovai
[22:28:35] *** maro has quit IRC
[22:28:43] *** jlouie has joined #chromium
[22:28:59] *** fishd has quit IRC
[22:29:16] <pinkerton> rsesek: the branch is 342, and has already been cut
[22:29:27] <trungl> rohitrao: hopefully?
[22:29:30] <rsesek> pinkerton: ok. thanks
[22:29:32] *** cbentzel has joined #chromium
[22:29:49] <trungl> rohitrao: we need a thousand monkeys working on this, and we can figure out the average time to reproduce
[22:29:56] <trungl> hrm, maybe that came out wrong
[22:29:57] <rsesek> pinkerton: cookie manager jank CL will land tonight and merge
[22:30:03] <pinkerton> thanks
[22:30:12] <rohitrao> yeah, that came out wrong
[22:30:22] *** D-V has quit IRC
[22:31:57] *** jrmuizel has quit IRC
[22:32:13] *** jrmuizel has joined #chromium
[22:36:59] <rohitrao> motownavi: I think tabs used to be layer-backed, yes
[22:37:06] <motownavi> ok, that's why then
[22:38:01] <motownavi> toView:nil is more "correct", though (for some definition of "correct")
[22:39:54] *** erikkay has quit IRC
[22:42:01] <rohitrao> trungl, jrg: haha, loading 2% of 95295 stack frames.  looks like an infinite loop? :)
[22:42:54] <jrg> well see... in 506 years.
[22:46:22] <rsesek> sherrifs: you may want to throttle the tree.. there's a lot of stacked up builders
[22:47:16] <rohitrao> jrg: openBookmarkFolderFromButtonAndCloseOldOne: is calling closeBookmarkFolder, which through a notification is calling parentWindowWillClose, which is calling closeAllBookmarkFolders, which through a notification is...
[22:47:59] <jrg> rohitrao: DOH!
[22:48:03] <jrg> rohitrao: send bug to me
[22:48:40] <jrg> rohitrao: how did you trigger this manually?  I certainly tried to open and close bookmark folders before landing... what did I miss?
[22:48:50] <rohitrao> jrg: you're cc'ed on http://code.google.com/p/chromium/issues/detail?id=37228 .  only happens when in fullscreen mode
[22:49:08] <jrg> ah
[22:49:16] *** pfeldman has quit IRC
[22:49:19] <jrg> what a big freakin surprise that fullscreen stabs me
[22:49:44] <motownavi> my break
[22:49:52] <thakis> jrg: hovering over bookmarks in the bookmark bar gives my window buttons (close, minimize, zoom) an "active" look in my local build
[22:50:07] <thakis> jrg: is that your doing, or did i break something locally?
[22:50:13] <jrg> thakis: was filed at least twice.  Is funny.
[22:50:29] <trungl> clearly we should all head over and +1 it
[22:51:10] <pinkerton> yeah, that's funky
[22:51:30] *** sbyer_afk is now known as sbyer
[22:52:34] <chase> jam2: failed again
[22:53:03] <chase> jam2: nsylvain suggested maybe the test just happens to be almost at the timeout limit in the success cases, too
[22:53:23] <chase> jam2: in the most recent green build, the current and ref build took ~470s each to run, the timeout is 600s
[22:53:53] <nsylvain> so that would be a significant slowdown
[22:53:57] <nsylvain> but not impossible
[22:54:19] <chase> nsylvain: if we could get the test to talk after it completed each subtest, that would be a quick test
[22:54:24] <chase> err quick fix
[22:54:34] <chase> who owns the dromaeo test?  antonm?
[22:54:40] <nsylvain> i believe so yes
[22:56:13] <chase> jam2: is there a bug on file already?  if not, file a bug against antonm, ask him to take a look.  cc me, too, if you do it.
[23:01:04] *** krisr_mbp_ has joined #chromium
[23:02:01] <jam2> chase: yeah i saw it failed.  i wonder why it started happenign with his change
[23:02:02] *** markmentovai has quit IRC
[23:02:10] *** markmentovai has joined #chromium
[23:02:10] *** ChanServ sets mode: +v markmentovai
[23:02:15] <jam2> chase: perhaps him limiting the memory makes it slower?
[23:02:25] *** krisr_mbp has quit IRC
[23:02:25] *** krisr_mbp_ is now known as krisr_mbp
[23:02:32] <jam2> chase: actually, the failure happened before the revert, no?
[23:03:16] <jam2> chase: i was confused, i meant it passed once before my revert.  but it was flakey so that's not unexpected
[23:03:17] <rsesek> I have to step out for 10 minutes. If I break something horribly, revert. but the trybots were happy
[23:03:38] *** fishd_ has quit IRC
[23:03:42] *** victorw has joined #chromium
[23:03:57] <chase> jam2: yeah, i thought i saw the current build fail, but it looks like it passed
[23:04:25] <chase> jam2: so it looks like the revert sped up the test (or doesn't cause it to hang, whichever)
[23:04:31] *** fishd_ has joined #chromium
[23:04:31] *** ChanServ sets mode: +v fishd_
[23:04:46] *** Zucca has quit IRC
[23:04:49] <jam2> let's wait a few runs to see if there's no red.  if not, then we can be kinda sure that the change cuased it
[23:04:57] <chase> jam2: sgtm
[23:04:57] <jam2> chase: i think no need to file a bug if the change is reverted
[23:05:36] <chase> jam2: we should try to break dromaeo up so we get output as it runs each of the subtests
[23:06:09] <chase> jam2: that way a hang in any one of the tests will be more noticeable and we don't need to worry about hitting the 600s timeout if the whole test takes longer
[23:06:13] <chase> jam2: i'll file that
[23:07:05] *** sundiamonde has joined #chromium
[23:07:08] <jam2> chase: thanks
[23:07:39] *** scottmattocks has quit IRC
[23:08:19] *** senorblanco has joined #chromium
[23:08:19] *** ChanServ sets mode: +v senorblanco
[23:09:13] *** markmentovai has quit IRC
[23:09:31] *** markmentovai has joined #chromium
[23:09:32] *** ChanServ sets mode: +v markmentovai
[23:12:09] *** General13372 has joined #chromium
[23:12:10] *** markmentovai has quit IRC
[23:12:42] *** markmentovai has joined #chromium
[23:12:43] *** ChanServ sets mode: +v markmentovai
[23:12:51] *** rubenbb has joined #chromium
[23:13:32] <jam2> nsylvain/chase: just to confirm, http://chrome-buildbot:8010/builders/Vista%20Tests%20(dbg)(1)/builds/20078/steps/unit_tests/logs/stdio is another grd problem?
[23:13:37] *** agl has quit IRC
[23:15:15] *** markmentovai has quit IRC
[23:15:24] *** General1337 has quit IRC
[23:15:46] *** markmentovai has joined #chromium
[23:15:46] *** ChanServ sets mode: +v markmentovai
[23:16:12] *** tcmg has quit IRC
[23:18:35] *** CrazyRobot has quit IRC
[23:18:43] *** cst has quit IRC
[23:18:48] *** abarth has joined #chromium
[23:18:48] *** ChanServ sets mode: +v abarth
[23:20:17] <chase> jam2: not sure
[23:21:52] <jam2> i'll try to clobber
[23:25:34] <rohitrao> jrg: in [-BookmarkBarController viewDidMoveToWindow], you set up an observer for windowWillClose.  Why?
[23:25:49] <jrg> rohitrao: 1 sec
[23:26:15] <rohitrao> jrg: or, more importantly, why is that only set in viewDidMoveToWindow (so it only exists after the BookmarkBar is moved between windows)
[23:26:22] <rohitrao> jrg: no hurry
[23:28:11] *** maro has joined #chromium
[23:30:43] <jrg> rohitrao: ah
[23:31:08] <jrg> rohitrao: it's so all bookmark bar folder windows get closed (which may be unnecessary since I've since made them all child windows.)
[23:31:24] *** romainhuet has quit IRC
[23:31:35] <jrg> rohitrao: can't add that code before this view is placed on a window, which is NOT at awakeFromNib time.
[23:32:04] <jrg> rohitrao: this is an NSViewController, not NSWindowController.
[23:33:19] <jrg> rohitrao: closeAllBookmarkFolders and closeBookmarkFolder, of the bookmark_bar_controller, should not trigger a parentWindowWillClose callback on the bar controller.
[23:34:29] *** pinkerton has quit IRC
[23:34:46] <jrg> rohitrao: the problem may be that the code only expects one viewDidMoveToWindow to ever get called, but for fullscreen that's not true.  Perhaps the code should removeObserver:self blah bah at the beginning of that routine.
[23:35:04] *** estade has quit IRC
[23:35:08] *** tcmg has joined #chromium
[23:35:20] *** mpcomplete_wfh has quit IRC
[23:35:26] *** estade has joined #chromium
[23:35:26] *** ChanServ sets mode: +v estade
[23:37:38] *** fishd has joined #chromium
[23:37:38] *** ChanServ sets mode: +v fishd
[23:40:17] *** lilmatt has joined #chromium
[23:40:37] <rohitrao> jrg: ah, sorry, i was missing the initial viewDidMoveToWindow call.  let me try removing existing observers
[23:41:16] *** fishd_ has quit IRC
[23:44:05] *** tedoc2000 has quit IRC
[23:45:39] <estade> in light of finnur's email, what is with the tree closed message
[23:46:02] <estade> jam2, lzheng: is someone on the failure?
[23:46:47] *** jparent has joined #chromium
[23:47:04] <estade> davemoore, eglaysher, rsesek, victorw: ^
[23:47:08] *** Venom_X is now known as Venom_bbl
[23:47:38] <jam2> estade: none of the changes looked related, so i had made that builder do another run to see if it reproduces
[23:48:03] *** Bleak has joined #chromium
[23:48:09] <rsesek> not my fault
[23:48:13] <rohitrao> jrg: removing observers seems to work
[23:48:22] <jrg> rohitrao: excellent.
[23:48:43] <rohitrao> although now the overlay disappears when we move into the bookmark menus :)
[23:48:48] <rohitrao> trungl: ^^^
[23:48:48] <rsesek> jam2: that test is also problematic under mac valgrind
[23:49:01] <rsesek> jam2: rather, that suite is problematic
[23:49:04] <jrg> rohitrao: you mean the "you done enter fullscreen" overlay?
[23:49:12] <jrg> rohitrao: perhaps that's fine.
[23:49:17] *** tedoc2000 has joined #chromium
[23:49:21] <jam2> rsesek: so, are you saying this test has been failing before?
[23:49:31] <estade> jam2: thanks. http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/aafcfa713344a5ff#
[23:49:54] <rsesek> jam2: I don't know if that specific test, but the ProfileSyncServiceAutofillTest suite has been flaky off and on under mac valgrind
[23:50:22] <rsesek> http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/3533/steps/valgrind%20test:%20unit/logs/stdio
[23:51:17] <jam2> looks like it cycled green now.  i'll mark it flakey, file a bug, and open the tree
[23:51:25] <rohitrao> jrg: the tabstrip/toolbar that slides down slides back up again once you enter the menu.  it should probably stay around :)
[23:51:56] <jrg> rohitrao: yeah.  probably.  Don't know why that would go away when bookmark entered.
[23:52:11] *** cbentzel has quit IRC
[23:52:33] <thakis> yay, my chrome just died when i clicked a bookmark folder :-/
[23:52:35] <rohitrao> we're set up to dismiss the overlay once the mouse leaves it
[23:52:41] <rohitrao> thakis: are you in fullscreen mode? ;)
[23:52:57] <rohitrao> or, have you switched into and back out of fullscreen mode?
[23:53:01] <thakis> rohitrao: no. i was in fullscreen mode earlier today
[23:53:03] <thakis> rohitrao: yes
[23:53:05] <rohitrao> yeah, that's why
[23:53:37] <jrg> ls
[23:53:45] * rohitrao needs to audit all of the code that listens to window-level notifications
[23:53:54] <jrg> argh... /me hates how virtual machines confuse which app is "foreground"...
[23:54:11] <rsesek> jrg: run it in coherence mode?
[23:54:19] <rsesek> or whatever your vm software calls it
[23:54:27] <jrg> rsesek: makes it harder to cut and paste between machines.
[23:55:55] *** systemIX has quit IRC
[23:56:48] *** jparent has quit IRC

top